fix(b-table): fix sorting for negative numeric string (#7134)

jongwoo328 · web-flow · commit 46360a7c466c · 2025-03-26T08:50:22.000+01:00
diff --git a/src/components/table/helpers/default-sort-compare.spec.js b/src/components/table/helpers/default-sort-compare.spec.js
@@ -109,4 +109,18 @@ describe('table/helpers/default-sort-compare', () => {
     expect(defaultSortCompare(x, w, optionsNullLast)).toBe(-1)
     expect(defaultSortCompare(w, x, optionsNullLast)).toBe(1)
   })
+
+  it('sorts numeric string correctly', async () => {
+    const options = { sortBy: 'a', numeric: true }
+    expect(defaultSortCompare({ a: '1' }, { a: '2' }, options)).toBe(-1)
+    expect(defaultSortCompare({ a: '2' }, { a: '1' }, options)).toBe(1)
+    expect(defaultSortCompare({ a: '1' }, { a: '1' }, options)).toBe(0)
+    expect(defaultSortCompare({ a: '-1' }, { a: '1' }, options)).toBe(-1)
+    expect(defaultSortCompare({ a: '1' }, { a: '-1' }, options)).toBe(1)
+    expect(defaultSortCompare({ a: '0' }, { a: '0' }, options)).toBe(0)
+    expect(defaultSortCompare({ a: '1.234' }, { a: '1.567' }, options)).toBe(-1)
+    expect(defaultSortCompare({ a: '1.561' }, { a: '1.234' }, options)).toBe(1)
+    expect(defaultSortCompare({ a: '-10' }, { a: '-100' }, options)).toBe(1)
+    expect(defaultSortCompare({ a: '-20' }, { a: '-30' }, options)).toBe(1)
+  })
 })
diff --git a/src/constants/regex.js b/src/constants/regex.js
@@ -9,7 +9,7 @@ export const RX_HASH_ID = /^#[A-Za-z]+[\w\-:.]*$/
 export const RX_HTML_TAGS = /(<([^>]+)>)/gi
 export const RX_HYPHENATE = /\B([A-Z])/g
 export const RX_LOWER_UPPER = /([a-z])([A-Z])/g
-export const RX_NUMBER = /^[0-9]*\.?[0-9]+$/
+export const RX_NUMBER = /^[-]?[0-9]*\.?[0-9]+$/
 export const RX_PLUS = /\+/g
 export const RX_REGEXP_REPLACE = /[-/\\^$*+?.()|[\]{}]/g
 export const RX_SPACES = /[\s\uFEFF\xA0]+/g
