chore(compat): disable tests related to has-listener in Vue 3

xanf · xanf · commit 35c888e91a23 · 2022-10-25T00:35:54.000+03:00
There is no way to answer, if we have listeners for even when using
Vue3 compat build with $on available. Disable these tests for now,
these could be enabled later, when INSTANCE_EVENT_EMITTER flag will
be disabled
diff --git a/src/components/table/table-tbody-row-events.spec.js b/src/components/table/table-tbody-row-events.spec.js
@@ -1,4 +1,5 @@
 import { mount } from '@vue/test-utils'
+import { isVue3 } from '../../vue'
 import { waitNT } from '../../../tests/utils'
 import { BTable } from './table'
 
@@ -245,6 +246,11 @@ describe('table > tbody row events', () => {
   })
 
   it('should not emit row-hovered event when a row is hovered and no listener', async () => {
+    if (isVue3) {
+      // We can't track if we have an event listener in vue3 so we skip this test for vue 3
+      return
+    }
+
     const wrapper = mount(BTable, {
       propsData: {
         fields: testFields,
@@ -309,6 +315,11 @@ describe('table > tbody row events', () => {
   })
 
   it('should not emit row-unhovered event when a row is hovered and no listener', async () => {
+    if (isVue3) {
+      // We can't track if we have an event listener in vue3 so we skip this test for vue 3
+      return
+    }
+
     const wrapper = mount(BTable, {
       propsData: {
         fields: testFields,
diff --git a/src/components/table/table-tbody-transition.spec.js b/src/components/table/table-tbody-transition.spec.js
@@ -1,5 +1,6 @@
 import { config as vtuConfig, mount } from '@vue/test-utils'
 import { TransitionGroupStub } from '../../../tests/components'
+import { isVue3 } from '../../vue'
 import { BTable } from './table'
 
 // Stub `<transition-group>` component
@@ -9,6 +10,14 @@ const testItems = [{ a: 1, b: 2, c: 3 }, { a: 5, b: 5, c: 6 }, { a: 7, b: 8, c:
 const testFields = ['a', 'b', 'c']
 
 describe('table > tbody transition', () => {
+  if (isVue3) {
+    // @vue/test-utils does not support stubbing transition, so impossible to test ATM
+
+    // adding dummy test to keep jest happy
+    it('skipped due to vue3', () => {})
+    return
+  }
+
   it('tbody should not be a transition-group component by default', async () => {
     const wrapper = mount(BTable, {
       attachTo: document.body,
diff --git a/src/components/table/table-thead-events.spec.js b/src/components/table/table-thead-events.spec.js
@@ -1,11 +1,16 @@
 import { mount } from '@vue/test-utils'
+import { isVue3 } from '../../vue'
 import { BTable } from './table'
 
 const testItems = [{ a: 1, b: 2, c: 3 }]
 const testFields = [{ key: 'a', label: 'A' }, { key: 'b', label: 'B' }, { key: 'c', label: 'C' }]
 
 describe('table > thead events', () => {
   it('should not emit head-clicked event when a head cell is clicked and no head-clicked listener', async () => {
+    if (isVue3) {
+      // We can't track if we have an event listener in vue3 so we skip this test for vue 3
+      return
+    }
     const wrapper = mount(BTable, {
       propsData: {
         fields: testFields,
diff --git a/src/mixins/has-listener.js b/src/mixins/has-listener.js
@@ -2,13 +2,16 @@
 // either via `v-on:name` (in the parent) or programmatically
 // via `vm.$on('name', ...)`
 // See: https://github.com/vuejs/vue/issues/10825
-import { Vue } from '../vue'
+import { isVue3, Vue } from '../vue'
 import { isArray, isUndefined } from '../utils/inspect'
 
 // @vue/component
 export const hasListenerMixin = Vue.extend({
   methods: {
     hasListener(name) {
+      if (isVue3) {
+        return true
+      }
       // Only includes listeners registered via `v-on:name`
       const $listeners = this.$listeners || {}
       // Includes `v-on:name` and `this.$on('name')` registered listeners
