Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bmaltais/kohya_ss
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v24.1.3
Choose a base ref
...
head repository: bmaltais/kohya_ss
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v24.1.4
Choose a head ref
  • 4 commits
  • 6 files changed
  • 2 contributors

Commits on May 11, 2024

  1. Minor fixes (#2480) 

    * Update common_gui.py

Little fix to the `validate_model_path` function to properly handle a folder path. Currently, it errors out when a folder path is selected for a training with diffusers. 😊

* Update lora_gui.py

Switching the validation type for the resume training state path from 'file' to 'folder'.
😊

* Update common_gui.py

format

* Update common_gui.py

My last fix was wrong and was returning errors when using a default model or when the VAE was not defined. This new fix works with all possibilities.
However, when a diffusers folder is used, `validate_file_path` will show a failed check, but the operation will still succeed because `validate_folder_path` will return successfully.
    @sangoi-exe
    sangoi-exe authored May 11, 2024
    Configuration menu
    Copy the full SHA
    bfc2856 View commit details
    Browse the repository at this point in the history

  2. Fix resume folder path validation

    @bmaltais
    bmaltais committed May 11, 2024
    Configuration menu
    Copy the full SHA
    d010b0d View commit details
    Browse the repository at this point in the history

  3. Fix finetuning meta file creation (#2488)

    @bmaltais
    bmaltais authored May 11, 2024
    Configuration menu
    Copy the full SHA
    3b771f5 View commit details
    Browse the repository at this point in the history

  4. Merge pull request #2491 from bmaltais/dev 

    v24.1.4
    @bmaltais
    bmaltais authored May 11, 2024
    Configuration menu
    Copy the full SHA
    5ed5623 View commit details
    Browse the repository at this point in the history
Loading