feat(op): use RollupCostData instead of full encoding #1491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaniPopes
reviewed
Jun 5, 2024
| /// The number of zeroes in the transaction. | ||
| pub(crate) zeroes: u64, | ||
| /// The number of ones in the transaction. | ||
| pub(crate) ones: u64, |
| pub fn from_bytes(bytes: &[u8]) -> Self { | ||
| let mut data = RollupCostData::default(); | ||
| let mut i = 0; | ||
| while i < bytes.len() { |
There was a problem hiding this comment.
the same functionality exists in gas costs, this should reuse that
There was a problem hiding this comment.
wdym / where? the counting for op data gas costs at least we want to remove, and put here instead
There was a problem hiding this comment.
revm/crates/interpreter/src/gas/calc.rs
Lines 354 to 374 in b7b92ae
DaniPopes
reviewed
Jun 5, 2024
crates/revm/src/optimism/l1block.rs
Outdated
| let mut rollup_data_gas_cost = U256::from(cost_data.ones.get()) | ||
| .saturating_mul(U256::from(NON_ZERO_BYTE_COST)) | ||
| .saturating_add( | ||
| U256::from(cost_data.zeroes.get()).saturating_mul(U256::from(ZERO_BYTE_COST)), |
There was a problem hiding this comment.
pretty sure all the arithmetic in this function and *fjord can be scaled down to use u64
nope, was busy with other things, can pick this back up this week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP to ultimately replace the
tx_envelopepart of theOptimismFieldswith a new struct.Currently it just introduces the struct, which basically mirrors the
RollupCostDatafrom op-geth, and uses it in a few places. The plan is to first integrate this internally, without breakingOptimismFields, and once it is properly tested, breakOptimismFieldsto use this instead.