Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaks in jQuery.noConflict(true) Scenario #67

Closed
jeffrose opened this issue Dec 13, 2012 · 4 comments
Closed

Breaks in jQuery.noConflict(true) Scenario #67

jeffrose opened this issue Dec 13, 2012 · 4 comments

Comments

@jeffrose
Copy link

While the various modules are surrounded by...

define(['jquery', ...], function( $, ... ) {

... many of them make references to the global jQuery variable, which does not exist if jQuery.noConflict(true); has been called.

In general AMD modules should avoid accessing variables in the global scope.
@daffl
Copy link
Contributor

daffl commented Dec 13, 2012

Sounds familiar ;) I guess we'll have to go through it and just change everything to $.

@jeffrose
Copy link
Author

At least it should be an easy fix. :-)

@jeffrose
Copy link
Author

I assume this will be in the next release. Do you know when that will be?

@daffl
Copy link
Contributor

daffl commented Dec 14, 2012

I wanted to get out a patch version soon. A pull request would greatly speed up the process.

@jeffrose jeffrose mentioned this issue Dec 15, 2012
Closed
@daffl daffl mentioned this issue Feb 6, 2013
Merged
@daffl daffl closed this as completed in 69f7216 Feb 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated jQuery References
2 participants
@daffl @jeffrose