WIP: Migration for Bouncy Castle types to java.security types.
#3354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks fine in general. Can we progress this to the point where we can delete the |
(If/when bitcoinj migrates to secp256k1-jdk, the definitions can come from that package)
These accessors both return BigInteger, so it's an easy switch. Other uses of values from BC_CURVE are (for now) dependent on BC types.
msgilligan
force-pushed
the
msgilligan/ECKey-rename-CURVE-to-BC_CURVE
branch
from
9db6a29
to
3b22781
Compare
I think we can, but we might have to create a secp256k1-jdk wrapper for curve parameters, so we can get things like point types in the correct format for either secp256k1-ffm or secp256k1-bouncy. I think this will allow us to minimize format conversion on point types. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.