Don't call removeForReorg if DisconnectTip fails

sdaftuar · sdaftuar · commit d5fa33d4c092 · 2015-11-17T15:25:20.000-05:00
diff --git a/src/main.cpp b/src/main.cpp
@@ -2296,11 +2296,8 @@ static bool ActivateBestChainStep(CValidationState &state, CBlockIndex *pindexMo
     // Disconnect active blocks which are no longer in the best chain.
     bool fBlocksDisconnected = false;
     while (chainActive.Tip() && chainActive.Tip() != pindexFork) {
-        if (!DisconnectTip(state, chainparams.GetConsensus())) {
-            // Probably an AbortNode() error, but try to keep mempool consistent anyway
-            mempool.removeForReorg(pcoinsTip, chainActive.Tip()->nHeight + 1);
+        if (!DisconnectTip(state, chainparams.GetConsensus()))
             return false;
-        }
         fBlocksDisconnected = true;
     }
 
@@ -2334,9 +2331,6 @@ static bool ActivateBestChainStep(CValidationState &state, CBlockIndex *pindexMo
                     break;
                 } else {
                     // A system error occurred (disk space, database error, ...).
-                    // Probably gonna shut down ASAP, but try to keep mempool consistent anyway
-                    if (fBlocksDisconnected)
-                        mempool.removeForReorg(pcoinsTip, chainActive.Tip()->nHeight + 1);
                     return false;
                 }
             } else {
