Avoid copying CNodeStats to make helgrind OK with buggy std::string

TheBlueMatt · TheBlueMatt · commit ae683c1b1960 · 2017-02-10T11:32:40.000-05:00
diff --git a/src/net.cpp b/src/net.cpp
@@ -2420,9 +2420,8 @@ void CConnman::GetNodeStats(std::vector<CNodeStats>& vstats)
     vstats.reserve(vNodes.size());
     for(std::vector<CNode*>::iterator it = vNodes.begin(); it != vNodes.end(); ++it) {
         CNode* pnode = *it;
-        CNodeStats stats;
-        pnode->copyStats(stats);
-        vstats.push_back(stats);
+        vstats.emplace_back();
+        pnode->copyStats(vstats.back());
     }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2420,9 +2420,8 @@ void CConnman::GetNodeStats(std::vector<CNodeStats>& vstats)`
`2420`	`2420`	`vstats.reserve(vNodes.size());`
`2421`	`2421`	`for(std::vector<CNode*>::iterator it = vNodes.begin(); it != vNodes.end(); ++it) {`
`2422`	`2422`	`CNode* pnode = *it;`
`2423`		`- CNodeStats stats;`
`2424`		`- pnode->copyStats(stats);`
`2425`		`- vstats.push_back(stats);`
	`2423`	`+ vstats.emplace_back();`
	`2424`	`+ pnode->copyStats(vstats.back());`
`2426`	`2425`	`}`
`2427`	`2426`	`}`
`2428`	`2427`