Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: FastAI #2571

Merged
merged 63 commits into from
Jun 29, 2022
Merged

feat: FastAI #2571

merged 63 commits into from
Jun 29, 2022

Conversation

aarnphm
Copy link
Contributor

@aarnphm aarnphm commented Jun 8, 2022 •
edited
Loading

Signed-off-by: Aaron Pham [email protected]

FastAI 🚀 📈 🌔
It is a big PR, maybe i will rebase this to smaller PR

@pep8speaks
Copy link

pep8speaks commented Jun 8, 2022 •
edited
Loading

Hello @aarnphm, Thanks for updating this PR.

There are currently no PEP 8 issues detected in this PR. Cheers! 🍻

Comment last updated at 2022-06-29 21:35:41 UTC

@codecov
Copy link

codecov bot commented Jun 8, 2022 •
edited
Loading

Codecov Report

Merging #2571 (f7d98b7) into main (1d58a78) will increase coverage by 0.22%.
The diff coverage is 95.45%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2571      +/-   ##
==========================================
+ Coverage   69.22%   69.45%   +0.22%     
==========================================
  Files         127      129       +2     
  Lines        9996    10084      +88     
==========================================
+ Hits         6920     7004      +84     
- Misses       3076     3080       +4
Impacted Files Coverage Δ
bentoml/_internal/frameworks/fastai.py 95.06% <95.06%> (ø)
bentoml/__init__.py 100.00% <100.00%> (ø)
bentoml/fastai.py 100.00% <100.00%> (ø)

@parano parano requested review from larme and sauyon June 8, 2022 22:10
sauyon
sauyon reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of mostly doc comments.

@aarnphm aarnphm force-pushed the feat/fastai branch 3 times, most recently from d0dcc61 to fd68c50 Compare June 9, 2022 07:10
parano
parano reviewed Jun 9, 2022
View reviewed changes
parano
parano reviewed Jun 9, 2022
View reviewed changes
aarnphm and others added 14 commits June 9, 2022 21:27
@aarnphm
fix: pip args failed to register
f157c16 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
chore: updates
595751d 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
feat: fastai
3c92f3b 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
revert: changes
be2f1bf 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm @sauyon
Apply suggestions from code review
aa62077 
Co-authored-by: Sauyon Lee <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
chore: using autotypehint
e46e796 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
feat: tests ci
51e5736 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
revert: build.sh
a1b60e4 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
feat: tests ci
226b212 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
chore: modify names
639a1a1 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
chore: remove wrong files
b67f391 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
chore: wip
fa342de 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
chore: remove backwards warning
5741af7 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
chore: updates address from PR
b740e76 
Signed-off-by: Aaron Pham <[email protected]>
@aarnphm
chore: testing
6958ea1 
Signed-off-by: Aaron Pham <[email protected]>
parano
parano reviewed Jun 28, 2022
View reviewed changes
@sauyon
Copy link
Contributor

sauyon commented Jun 28, 2022

Why is the docs build failing now?

@sauyon sauyon added this to the BentoML 1.0 Release milestone Jun 29, 2022
@ssheng ssheng merged commit bb9a141 into bentoml:main Jun 29, 2022
@aarnphm aarnphm deleted the feat/fastai branch July 1, 2022 01:25
aarnphm added a commit to aarnphm/BentoML that referenced this pull request Jul 29, 2022
@aarnphm @sauyon
@parano @yetone @ssheng
feat: FastAI framework implementation (bentoml#2571)
6c56f78 
* fix: pip args failed to register

Signed-off-by: Aaron Pham <[email protected]>

* chore: updates

Signed-off-by: Aaron Pham <[email protected]>

* feat: fastai

Signed-off-by: Aaron Pham <[email protected]>

* revert: changes

Signed-off-by: Aaron Pham <[email protected]>

* Apply suggestions from code review

Co-authored-by: Sauyon Lee <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>

* chore: using autotypehint

Signed-off-by: Aaron Pham <[email protected]>

* feat: tests ci

Signed-off-by: Aaron Pham <[email protected]>

* revert: build.sh

Signed-off-by: Aaron Pham <[email protected]>

* feat: tests ci

Signed-off-by: Aaron Pham <[email protected]>

* chore: modify names

Signed-off-by: Aaron Pham <[email protected]>

* chore: remove wrong files

Signed-off-by: Aaron Pham <[email protected]>

* chore: wip

Signed-off-by: Aaron Pham <[email protected]>

* chore: remove backwards warning

Signed-off-by: Aaron Pham <[email protected]>

* chore: updates address from PR

Signed-off-by: Aaron Pham <[email protected]>

* chore: testing

Signed-off-by: Aaron Pham <[email protected]>

* feat: conf.py fix types

Signed-off-by: Aaron Pham <[email protected]>

* revert: scripts

Signed-off-by: Aaron Pham <[email protected]>

* chore: updates ci

Signed-off-by: Aaron Pham <[email protected]>

* test: wip

Signed-off-by: Aaron Pham <[email protected]>

* feat: fastai testing

Signed-off-by: Aaron Pham <[email protected]>

* chore: fix with new PR

Signed-off-by: Aaron Pham <[email protected]>

* chore: updates documentation spellcheck

Signed-off-by: Aaron Pham <[email protected]>

* feat: fastai docs

Signed-off-by: Aaron Pham <[email protected]>

* chore: remove testfiles

Signed-off-by: Aaron Pham <[email protected]>

* Update docs/source/frameworks/fastai.rst

Co-authored-by: Chaoyu <[email protected]>

* chore: apply suggestion from review

Co-authored-by: yetone <[email protected]>

* chore: update frameworks include files for CI

Signed-off-by: Aaron Pham <[email protected]>

* chore: remove old tests, update docs + add custom models for testing

Signed-off-by: Aaron Pham <[email protected]>

* chore: updates fastcore requirements under model context

Signed-off-by: Aaron Pham <[email protected]>

* chore: add unit tests for fastai to cover frameworks test didn't cover

Signed-off-by: Aaron Pham <[email protected]>

* Update bentoml/_internal/frameworks/fastai.py

Co-authored-by: Chaoyu <[email protected]>

* Update bentoml/_internal/frameworks/fastai.py

Co-authored-by: Chaoyu <[email protected]>

* chore: Apply suggestions from code review

Co-authored-by: Sauyon Lee <[email protected]>

* Update docs/source/frameworks/fastai.rst

Co-authored-by: Sauyon Lee <[email protected]>

* chore: address grammar changes

Signed-off-by: Aaron Pham <[email protected]>

* fix: remove comments

Signed-off-by: Aaron Pham <[email protected]>

* chore: add stanford links for imdb

Signed-off-by: Aaron Pham <[email protected]>

* Apply suggestions from code review

Co-authored-by: Sauyon Lee <[email protected]>

* Apply suggestions from code review

Co-authored-by: Sauyon Lee <[email protected]>

* chore: address docs comments and fix CI

Signed-off-by: Aaron Pham <[email protected]>

* chore: updates docs and remove unused code

Signed-off-by: Aaron Pham <[email protected]>

* chore: Apply suggestions from code review

Co-authored-by: Sauyon Lee <[email protected]>
Signed-off-by: Aaron Pham <[email protected]>

* perf: use LazyType instead of function imports

Signed-off-by: Aaron Pham <[email protected]>

* chore: depends on bentoml#2632 now

Signed-off-by: Aaron Pham <[email protected]>

* fix(ci): lock torch to 1.9.0 since fastai doesn't have support for 1.11 yet

Signed-off-by: Aaron Pham <[email protected]>

* fix: CI changes

Signed-off-by: Aaron Pham <[email protected]>

* chore: refactor fastai to recent resources

Signed-off-by: Aaron Pham <[email protected]>

* chore: revert docs/source from upstream/main

Signed-off-by: Aaron Pham <[email protected]>

* revert: refactor to another PR

Signed-off-by: Aaron Pham <[email protected]>

* chore: revert docs/source from upstream/main

Signed-off-by: Aaron Pham <[email protected]>

* chore: fastai

Signed-off-by: Aaron Pham <[email protected]>

* fix: CI

Signed-off-by: Aaron Pham <[email protected]>

* chore: revert python version for docs

Signed-off-by: Aaron Pham <[email protected]>

* chore: ci

Signed-off-by: Aaron Pham <[email protected]>

* chore: fix ci

Signed-off-by: Aaron Pham <[email protected]>

Co-authored-by: Sauyon Lee <[email protected]>
Co-authored-by: Chaoyu <[email protected]>
Co-authored-by: yetone <[email protected]>
Co-authored-by: Sean Sheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parano parano parano left review comments

@yetone yetone yetone left review comments

@ssheng ssheng ssheng approved these changes

@larme larme Awaiting requested review from larme

@bojiang bojiang Awaiting requested review from bojiang

@sauyon sauyon Awaiting requested review from sauyon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0rc3
Development

Successfully merging this pull request may close these issues.
8 participants
@aarnphm @pep8speaks @bojiang @sauyon @larme @parano @ssheng @yetone