-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Comparing changes
Open a pull request
base repository: basecamp/trix
base: v2.1.10
head repository: basecamp/trix
compare: v2.1.12
- 17 commits
- 14 files changed
- 6 contributors
Commits on Dec 10, 2024
-
Expose Trix.config.dompurify to allow users to configure DOMPurify. Additionally avoid stripping data-trix-* attributes.
Configuration menu - View commit details
-
Copy full SHA for da9d999 - Browse repository at this point
Copy the full SHA da9d999View commit details
Commits on Dec 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d910855 - Browse repository at this point
Copy the full SHA d910855View commit details -
Merge pull request #1208 from basecamp/dom-purify-config
Make DOMPurify configurable
Configuration menu - View commit details
-
Copy full SHA for 32b0431 - Browse repository at this point
Copy the full SHA 32b0431View commit details
Commits on Dec 17, 2024
-
If SAFE_FOR_XML is true all comments are removed from attachments. See: #1213
Configuration menu - View commit details
-
Copy full SHA for 692fa98 - Browse repository at this point
Copy the full SHA 692fa98View commit details -
Merge pull request #1214 from basecamp/disable-safe-for-xml
Allow comments in attachments
Configuration menu - View commit details
-
Copy full SHA for f4d8e5c - Browse repository at this point
Copy the full SHA f4d8e5cView commit details -
node-sass is deprecated and doesn't work on newer platforms (e.g. arm64)
Jacopo Beschi committedDec 17, 2024 Configuration menu - View commit details
-
Copy full SHA for 903b51f - Browse repository at this point
Copy the full SHA 903b51fView commit details -
Merge pull request #1215 from basecamp/switch-to-sass
Switch from node-sass to sass
Configuration menu - View commit details
-
Copy full SHA for 6214af4 - Browse repository at this point
Copy the full SHA 6214af4View commit details -
Use `compile` instead the deprecated `render` method. No changes to the generated `.css`. See https://sass-lang.com/documentation/js-api/functions/render/
Jacopo Beschi committedDec 17, 2024 Configuration menu - View commit details
-
Copy full SHA for b67b642 - Browse repository at this point
Copy the full SHA b67b642View commit details -
Reintroduce
yarn build --watch
#1215 indirectly removed the `--watch` mode, by switching SCSS compilation to a node.js file. This was required because the `sass` CLI doesn't support the `--function` for custom functions. Now reintroduce it back using `chokidar`. This also fixes `yarn start` command.
Jacopo Beschi committedDec 17, 2024 Configuration menu - View commit details
-
Copy full SHA for 37e9464 - Browse repository at this point
Copy the full SHA 37e9464View commit details -
Merge pull request #1216 from basecamp/fix-yarn-start
Reintroduce yarn build --watch
Configuration menu - View commit details
-
Copy full SHA for 4f279fd - Browse repository at this point
Copy the full SHA 4f279fdView commit details
Commits on Dec 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f4d64c2 - Browse repository at this point
Copy the full SHA f4d64c2View commit details -
Fix XSS via
javascript:
url in a linkPrevously, was possible to trigger XSS setting as link an URL like `javascript:alert('XSS')`. Fix it via a custom HTML input validation pattern to block both `javascript:` and `data:` URLs.
Jacopo Beschi committedDec 18, 2024 Configuration menu - View commit details
-
Copy full SHA for 12ee782 - Browse repository at this point
Copy the full SHA 12ee782View commit details
Commits on Dec 19, 2024
-
Switch from JS pattern to DOMPurity.isValidAttribute
This should any cover edge case not covered by the Regexp.
Jacopo Beschi committedDec 19, 2024 Configuration menu - View commit details
-
Copy full SHA for f432478 - Browse repository at this point
Copy the full SHA f432478View commit details
Commits on Dec 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 180c8d3 - Browse repository at this point
Copy the full SHA 180c8d3View commit details -
- use `isSafeAttribute` instead of `safeAttribute` - Extract conditional to an outer if - Add parenthesys for clarity
Jacopo Beschi committedDec 20, 2024 Configuration menu - View commit details
-
Copy full SHA for c707f41 - Browse repository at this point
Copy the full SHA c707f41View commit details -
Merge pull request #1218 from basecamp/refactor-xss-fix
Refactor link XSS patch
Configuration menu - View commit details
-
Copy full SHA for c4f0d6f - Browse repository at this point
Copy the full SHA c4f0d6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bf3e5a - Browse repository at this point
Copy the full SHA 7bf3e5aView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v2.1.10...v2.1.12