-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDBSCAN models require consistent version of sklearn to open #213
Comments
I'm not immediately sure what's going wrong here unfortunately. It seems like the version string from pp-sketchlib isn't as expected. Can you run Copying out some relevant parts for reference:
Looks like both sketchlib 2.0.0 and poppunk 2.4.0 are installed |
Note: a similar error appears in #210 |
Thanks for the quick answer. |
And |
Yes, that's the case (see list of packages attached). |
Could you try making a fresh environment with |
A new installation still gives me an error (see attached file). In this env, |
Ah, apologies, I now see the problem. From pp-sketchlib 2.0.0 From v2.5.0 this will be updated and fixed so they work together. The only thing I don't understand is why you aren't getting the version from the library file. Could you try running, in a python session:
|
Indeed, installing |
That's a different error now, which appears to be caused by scikit-learn changing their API. Can you try downgrading to v0.24? I'll need to put in a fix for this in future versions |
Would you be able to attach the fit.pkl file you are using here? |
Thanks! Downgrading to v0.24 solved the issue indeed. I attach here the pkl I'm using for this run. |
Ok, glad to hear this sorted the issue! The above pickle I think is the sample labels/dists pickle, do you also have a |
Do you mean this one? |
Ok that's great thank you, I can now replicate |
Just to state the problem and resolution here:
Most distributed models don't use this mode, so I don't forsee this being a big problem. I will add a note to the documentation that to use such a model the sklearn version needs to be downgraded, or that you may generally want to run refine model to give a simpler & faster model in the first place. |
Currently trying to install poppunk version 2.3.0.
I used to have a conda installation with poppunk 2.3.0 and poppunk_sketch 1.7.4. I created my own poppunk database to be able to run
poppunk_assign
,poppunk --fit-model
andpoppunk_visualise
. Now I need to re-create a conda environment that includes poppunk but it seems that when installing this same versionpoppunk_sketch
is not included in the installation, which I believe is needed to runpoppunk_assign
. I attach here a file with the exact error I get when trying to run the commands mentioned above (see poppunk_sketch_error.txt). I have also tried installing other versions in case that would solve the error but I also get an error that it's shown in the other file (see poppunk_2.4_error_message.txt, not sure this is related at all but just in case), I also tried installing it via pip, copying thepoppunk_sketch
exe... but nothing seems to work. I would really appreciate some help in here.Thanks a lot for the help in advance!
Victoria
poppunk_2.4_error_message.txt
poppunk_sketch_error.txt
The text was updated successfully, but these errors were encountered: