Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to c8 #996

Merged
merged 7 commits into from
Jul 18, 2023
Merged

migrate to c8 #996

merged 7 commits into from
Jul 18, 2023

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 6, 2023

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes: migrate to c8
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information: Migrate to c8, leveraging the v8 builtin coverage tools.

@nicolo-ribaudo
Copy link
Member

Can we setup a CI check that shows the current coverage, with codecov or something similar?

@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 7, 2023

Here is the current coverage report: https://app.codecov.io/gh/babel/babel-loader

Can you install the codecov GitHub application to this repo? So the coverage should show up in checks.

@nicolo-ribaudo
Copy link
Member

I see it as already enabled 🤔 I'll try to understand why it's not working

image image

@nicolo-ribaudo
Copy link
Member

Oh, it also stopped reporting the coverage in the babel/babel repo since July 5th

@JLHwung
Copy link
Contributor Author

JLHwung commented Jul 7, 2023 •
edited
Loading

The coverage report now looks good to me: https://app.codecov.io/github/babel/babel-loader/commit/3ed721a5c2c0af04dbac02d3f40ce20adcba3ee5/tree/src

it also stopped reporting the coverage in the babel/babel repo since July 5th

I have no idea why the codecov check is missing. Maybe the issue is on their sides.

@JLHwung JLHwung merged commit df36cba into main Jul 18, 2023
@nicolo-ribaudo nicolo-ribaudo deleted the migrate-to-c8 branch July 18, 2023 14:23
@nicolo-ribaudo
Copy link
Member

Codecov is back :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

@nicolo-ribaudo nicolo-ribaudo Awaiting requested review from nicolo-ribaudo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JLHwung @nicolo-ribaudo @liuxingbaoyu