Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove caller option check #1007

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Remove caller option check #1007

merged 4 commits into from
Nov 17, 2023

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Nov 9, 2023

Babel 7.12+ supports the .caller option. We can remove the feature detection now, which happens to fix compatibility between babel-loader and @babel/[email protected], since we disallowed calling loadPartialConfig synchronously.

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

Behaviour is not changed.

Does this PR introduce a breaking change?

  • Yes
  • No

Closes #1006

@JLHwung JLHwung force-pushed the remove-caller-option-check branch from f257306 to 4be2eae Compare November 9, 2023 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants