Fix loading of modules with TLA in Node.js 23 #16926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58223 |
JLHwung
approved these changes
Oct 23, 2024
|
The error is unrelated, probably there has been a new react-native release. |
liuxingbaoyu
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node.js versions that support
require(esm),require(esm-with-tla)throwsERR_REQUIRE_ASYNC_MODULE. Then our old wrong logic would see thate.code !== "ERR_REQUIRE_ESM", and thus re-throw the error rather than trying to load it withimport().This means that in Node.js 23 it's currently impossible to use plugins/presets/configs that use TLA, even when loading them with
transformAsync.When doing
import()after arequire()failed due to TLA Node.js currently fails an internal assertion (nodejs/node#55500), so this PR also includes a workaround for that.