Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Babel 8] fix: Throwing exceptions synchronously #16836

Merged
merged 1 commit into from
Sep 16, 2024
Merged

[Babel 8] fix: Throwing exceptions synchronously #16836

merged 1 commit into from
Sep 16, 2024

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Sep 13, 2024 •
edited
Loading

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Not only was it previously impossible to catch, the stack had almost no useful content.
Ref: babel/website#2961

file:///F:/git/website/node_modules/@babel/core/lib/config/index.js:22
      throw new Error("Starting from Babel 8.0.0, the 'loadPartialConfig' function expects a callback. If you need to call it synchronously, please use 'loadPartialConfigSync'.");
            ^

Error: Starting from Babel 8.0.0, the 'loadPartialConfig' function expects a callback. If you need to call it synchronously, please use 'loadPartialConfigSync'.
    at Module.loadPartialConfig (file:///F:/git/website/node_modules/@babel/core/lib/config/index.js:22:13)
    at F:\git\website\node_modules\@babel\core\cjs-proxy.cjs:33:18

@liuxingbaoyu liuxingbaoyu changed the title fix: Throwing exceptions synchronously [Babel 8] fix: Throwing exceptions synchronously Sep 13, 2024
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57943

@JLHwung JLHwung added the PR: Polish (next major) 💅 A type of pull request used for our changelog categories for next major release label Sep 16, 2024
@JLHwung JLHwung merged commit cd8ffa4 into babel:main Sep 16, 2024
53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
PR: Polish (next major) 💅 A type of pull request used for our changelog categories for next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@liuxingbaoyu @babel-bot @nicolo-ribaudo @JLHwung