always throw when add missing helpers (#10208)

tanhauhau · existentialism · commit f5ca0587d130 · 2019-07-12T12:53:55.000-05:00
diff --git a/packages/babel-core/src/transformation/file/file.js b/packages/babel-core/src/transformation/file/file.js
@@ -203,6 +203,9 @@ export default class File {
       if (res) return res;
     }
 
+    // make sure that the helper exists
+    helpers.ensure(name);
+
     const uid = (this.declarations[name] = this.scope.generateUidIdentifier(
       name,
     ));
diff --git a/packages/babel-core/test/api.js b/packages/babel-core/test/api.js
@@ -788,4 +788,28 @@ describe("api", function() {
       );
     });
   });
+
+  describe("missing helpers", function() {
+    it("should always throw", function() {
+      expect(() =>
+        babel.transformSync(``, {
+          configFile: false,
+          plugins: [
+            function() {
+              return {
+                visitor: {
+                  Program(path) {
+                    try {
+                      path.pushContainer("body", this.addHelper("fooBar"));
+                    } catch {}
+                    path.pushContainer("body", this.addHelper("fooBar"));
+                  },
+                },
+              };
+            },
+          ],
+        }),
+      ).toThrow();
+    });
+  });
 });
diff --git a/packages/babel-helpers/src/index.js b/packages/babel-helpers/src/index.js
@@ -280,6 +280,10 @@ export function getDependencies(name: string): $ReadOnlyArray<string> {
   return Array.from(loadHelper(name).dependencies.values());
 }
 
+export function ensure(name: string) {
+  loadHelper(name);
+}
+
 export const list = Object.keys(helpers)
   .map(name => name.replace(/^_/, ""))
   .filter(name => name !== "__esModule");

Original file line number	Diff line number	Diff line change
`@@ -203,6 +203,9 @@ export default class File {`
`203`	`203`	`if (res) return res;`
`204`	`204`	`}`
`205`	`205`
	`206`	`+ // make sure that the helper exists`
	`207`	`+ helpers.ensure(name);`
	`208`	`+`
`206`	`209`	`const uid = (this.declarations[name] = this.scope.generateUidIdentifier(`
`207`	`210`	`name,`
`208`	`211`	`));`