Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Requirements Boost Related #1038

Closed
wants to merge 6 commits into from

Conversation

TheSCREWEDSoftware
Copy link
Contributor

@TheSCREWEDSoftware TheSCREWEDSoftware commented Dec 15, 2024

Description

Updated Boost Requirements

From >= 1.78 to >= 1.78 up to 1.84 (for windows, linux and macos)
It seems others higher than .84 give errors. (windows only mentioned issue)

Updated the Boost header download to go to downloads of the versions instead of confusing the user with the "Most" recent version. (windows)

Also updated the msvc text to say which version of boost and msvc is being downloaded. (windows)

Related Issue

Closes

Thank you for contributing to the AzerothCore wiki.

Remember that the wiki is currently available in English and Spanish.

Updated Boost Requirements

From >= 1.78 to >= 1.78 up to 1.84
It seems others higher than .84 give errors.

Updated the Boost header download to go to downloads of the versions instead of confusing the user with the "Most" recent version.

Also updated the msvc text to say which version of boost and msvc is being downloaded.
@TheSCREWEDSoftware TheSCREWEDSoftware changed the title Update windows-requirements.md Updated Windows Requirements Boost Related Dec 15, 2024
@TheSCREWEDSoftware TheSCREWEDSoftware marked this pull request as draft December 15, 2024 14:50
@TheSCREWEDSoftware TheSCREWEDSoftware marked this pull request as ready for review December 15, 2024 14:53
@Kitzunu
Copy link
Member

Kitzunu commented Dec 15, 2024

1.85 works without issues

@TheSCREWEDSoftware
Copy link
Contributor Author

Correcetd all Boost from 1.84 to 1.85

@TheSCREWEDSoftware TheSCREWEDSoftware changed the title Updated Windows Requirements Boost Related Updated Requirements Boost Related Dec 15, 2024
@Kitzunu
Copy link
Member

Kitzunu commented Dec 19, 2024

we support all released boost versions.

@Kitzunu Kitzunu closed this Dec 19, 2024
@Kitzunu Kitzunu deleted the TheSCREWEDSoftware-patch-1 branch December 19, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants