Skip to content

feat(Core): Achievements #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
55Honey merged 1 commit into from
Jul 5, 2022
Merged

feat(Core): Achievements #47

55Honey merged 1 commit into from
Jul 5, 2022

Conversation

@noisiver
Copy link

@noisiver noisiver commented Jun 26, 2022

  • Added AchievementMethods
  • Added GetId to AchievementMethods
  • Added OnAchiComplete to PlayerHooks

Tested with:

local PLAYER_ON_ACHIEVEMENT_COMPLETE = 45

local function OnAchiComplete(event, player, achievement)
    print(player:GetName()..' has completed achievement with id '..achievement:GetId())
end
RegisterPlayerEvent(PLAYER_ON_ACHIEVEMENT_COMPLETE, OnAchiComplete)

Note: I wanted to add GetName() to AchievementMethods but locale kept causing a segmentation fault so I'm holding off on that for now

@noisiver noisiver changed the title Feat: Achievements feat(Core): Achievements Jun 26, 2022
@55Honey
Copy link

55Honey commented Jul 5, 2022

Tested, works as intended.

@55Honey 55Honey merged commit efba901 into azerothcore:master Jul 5, 2022
mostlynick3 pushed a commit to mostlynick3/mod-eluna that referenced this pull request Aug 5, 2025
@noisiver
feat(Core): Achievements (azerothcore#47)
480c524 
Achievements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@acidmanifesto acidmanifesto acidmanifesto approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@noisiver @55Honey @acidmanifesto