Skip to content

feat: add OnBattlegroundDesertion hook #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
r-o-b-o-t-o merged 4 commits into from
Jun 11, 2023
Merged

feat: add OnBattlegroundDesertion hook #146

r-o-b-o-t-o merged 4 commits into from
Jun 11, 2023

Conversation

@0xCiBeR
Copy link

@0xCiBeR 0xCiBeR commented Jun 5, 2023 •
edited by r-o-b-o-t-o
Loading

Added OnBattlegroundDesertion hook.

Sample Lua code to test:

local function onDeserter(event, player, type)
    player:SendAreaTriggerMessage( "It works!" )
    print("it works")
end
RegisterPlayerEvent(57, onDeserter)

@0xCiBeR
Copy link
Author

0xCiBeR commented Jun 5, 2023

Hey @r-o-b-o-t-o just leaving a ping here so you can check the PR when you have the time.. Thanks!

@0xCiBeR 0xCiBeR force-pushed the feat/OnBgDesertion branch from 23f1436 to 80a9bed Compare June 6, 2023 16:22
55Honey
55Honey reviewed Jun 6, 2023
View reviewed changes
@0xCiBeR
Copy link
Author

0xCiBeR commented Jun 9, 2023

Hey! Is there anything else required on my side to merge the PR? Seems tests passed fine :)

@55Honey
Copy link

55Honey commented Jun 9, 2023

Please be patient until it's reviewed. I can't think of anything missing from a quick glance.

@r-o-b-o-t-o
Copy link
Member

r-o-b-o-t-o commented Jun 11, 2023

Thanks for the PR!

Sorry for taking this long, I needed to remove another player hook first. This also resulted in your event being changed from 59 to 57. I edited your sample Lua code in your first message.

@r-o-b-o-t-o r-o-b-o-t-o merged commit 1abf244 into azerothcore:master Jun 11, 2023
@0xCiBeR 0xCiBeR deleted the feat/OnBgDesertion branch July 20, 2023 21:24
mostlynick3 pushed a commit to mostlynick3/mod-eluna that referenced this pull request Aug 5, 2025
@0xCiBeR
feat: add OnBattlegroundDesertion hook (azerothcore#146)
590c69a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@55Honey 55Honey 55Honey left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@0xCiBeR @55Honey @r-o-b-o-t-o