New table implementations need to be designed in order to comply with database normalization rules https://www.w3schools.in/dbms/database-normalization

Quick copilot review:

The provided SQL script modifies the motd table by adding several language-specific columns and migrating the existing text column data to the enUS column. Let's analyze this for database normalization compliance:

1. Adding Columns: The script adds columns for various languages (enUS, koKR, frFR, deDE, zhCN, zhTW, esES, esMX, ruRU).

2. Data Migration: It moves data from the text column to the enUS column.

3. Dropping Column: The text column is then dropped.

To ensure compliance with database normalization rules, especially the Third Normal Form (3NF), the following considerations should be made:

• 1NF (First Normal Form): Each table should have atomic columns. Adding multiple language-specific columns may violate this as it introduces redundancy.
• 2NF (Second Normal Form): All non-key attributes must be fully functional dependent on the primary key. The current structure may lead to partial dependencies if the table's primary key is not composite.
• 3NF (Third Normal Form): Non-key attributes should not have transitive dependencies. Adding multiple language columns can lead to transitive dependencies.

Recommendations

• Normalization: Consider creating a separate table for localized messages to avoid redundancy and ensure proper normalization. For example:

  CREATE TABLE `motd` (
    `id` INT PRIMARY KEY,
    `default_text` LONGTEXT
  );
  
  CREATE TABLE `motd_localized` (
    `motd_id` INT,
    `locale` VARCHAR(5),
    `localized_text` LONGTEXT,
    PRIMARY KEY (`motd_id`, `locale`),
    FOREIGN KEY (`motd_id`) REFERENCES `motd`(`id`)
  );

This structure will ensure that the database is normalized and follows best practices for managing localized content.

@Nyeriah , any suggestions regarding the commands affected by this PR or the OnMotdChange() script

Yes, they will crash if used from console. Handler in the command context is not guaranteed to be a player or have a valid session, so this needs to be checked

Thank you for this insight.
I meant to ask about to the command .server set motd [optional realm id] [message].
and the sScriptMgr->OnMotdChange(motdMessage);

My thoughts would be:

1. The command should be adjusted to also include the locale as an optional
2. The OnMotdChange() should also include the locale that got changed. As a results the function call would use 2 params instead of one.

Sure, it can be added as an optional, and it should default to english

Please keep the MOTD encoding, it's an AC thing to difficult it being removed
Also please check for redundant comments, self-explanatory code doesn't need to be commented (e.g avoid rewriting in English what the code already clearly does)

Code adjusted. Should be good to go.

Did you test this after the changes were made? If so we can merge

Yes, its tested and working. I had to fix the server command, but now everything is good to go.

Awesome. We can merge after DB Squash.

Great job :D

CI failing

Already on it ;)

Are you in the discord?

Yes. I am the japanese named avatar you responded earlier with the spell dbc in the dev-core channel ;)

I see I see