Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Configurable rest bones max experience #20759

Closed
rudylhm opened this issue Nov 28, 2024 · 9 comments · Fixed by #20836
Closed

Feature: Configurable rest bones max experience #20759

rudylhm opened this issue Nov 28, 2024 · 9 comments · Fixed by #20836

Comments

@rudylhm
Copy link

rudylhm commented Nov 28, 2024

Describe your feature request or suggestion in detail

My friends have unstable online times, and they want to accumulate more rest bonus XP while offline.

Describe a possible solution to your feature or suggestion in detail

The code is in src/server/game/Entities/Player/Player.cpp, line 10229.
Could you make "rest_bonus_max" configurable?

Additional context

No response

@Exitare
Copy link
Member

Exitare commented Nov 29, 2024

I am open to implement that after agreement is reached whether this should be implemented.

@TheSCREWEDSoftware
Copy link
Contributor

I wouldn't see a reason why this couldn't be implemented. Assuming isn't a blizzard limit client side. AzerothCore is always up for Pull Request than they get reviewed.

@Exitare
Copy link
Member

Exitare commented Nov 29, 2024

I disagree.
There should be an agreement whether this feature is acceptable before someone puts in the work in order to open a PR.
The PR in itself should then be reviewed based on its implementation and code style etc.
No one likes to waste time.

@TheSCREWEDSoftware
Copy link
Contributor

I wouldn't say it would go to waste their time. If wouldn't get approved they could turn in into a module :)

@Exitare
Copy link
Member

Exitare commented Nov 29, 2024

Again strong disagreement.
It shouldn't be a problem or a big deal to agree whether something is acceptable to be merged into the main before someone works on it.

@Nyeriah
Copy link
Member

Nyeriah commented Nov 29, 2024

If there's an objection to any given suggestion, the suggestions get closed with one of the maintainers justifying why it wouldn't be a good idea to accept it, or why it can't be accepted/implemented. Otherwise, it's implicit that every suggestion is valid and acceptable, being the actual implementation subject to review as every other PR is

@Kitzunu
Copy link
Member

Kitzunu commented Nov 30, 2024

make a pr and @ me in discord and I'll review it for yah @Exitare

@Kitzunu
Copy link
Member

Kitzunu commented Nov 30, 2024

It's a harmless implementation

@Exitare
Copy link
Member

Exitare commented Nov 30, 2024

Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants