-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Configurable rest bones max experience #20759
Comments
I am open to implement that after agreement is reached whether this should be implemented. |
I wouldn't see a reason why this couldn't be implemented. Assuming isn't a blizzard limit client side. AzerothCore is always up for Pull Request than they get reviewed. |
I disagree. |
I wouldn't say it would go to waste their time. If wouldn't get approved they could turn in into a module :) |
Again strong disagreement. |
If there's an objection to any given suggestion, the suggestions get closed with one of the maintainers justifying why it wouldn't be a good idea to accept it, or why it can't be accepted/implemented. Otherwise, it's implicit that every suggestion is valid and acceptable, being the actual implementation subject to review as every other PR is |
make a pr and @ me in discord and I'll review it for yah @Exitare |
It's a harmless implementation |
Thank you :) |
Describe your feature request or suggestion in detail
My friends have unstable online times, and they want to accumulate more rest bonus XP while offline.
Describe a possible solution to your feature or suggestion in detail
The code is in src/server/game/Entities/Player/Player.cpp, line 10229.
Could you make "rest_bonus_max" configurable?
Additional context
No response
The text was updated successfully, but these errors were encountered: