fix(headers): added support for setting header names that overlap with class methods; (#5831)

DigitalBrainJS · web-flow · commit d8b4ca0ea5f2 · 2023-08-25T21:07:51.000+03:00
diff --git a/.eslintrc.cjs b/.eslintrc.cjs
@@ -10,5 +10,6 @@ module.exports = {
     "sourceType": "module"
   },
   "rules": {
+    "no-cond-assign": 0
   }
 }
diff --git a/lib/core/AxiosHeaders.js b/lib/core/AxiosHeaders.js
@@ -282,7 +282,17 @@ class AxiosHeaders {
 
 AxiosHeaders.accessor(['Content-Type', 'Content-Length', 'Accept', 'Accept-Encoding', 'User-Agent', 'Authorization']);
 
-utils.freezeMethods(AxiosHeaders.prototype);
+// reserved names hotfix
+utils.reduceDescriptors(AxiosHeaders.prototype, ({value}, key) => {
+  let mapped = key[0].toUpperCase() + key.slice(1); // map `set` => `Set`
+  return {
+    get: () => value,
+    set(headerValue) {
+      this[mapped] = headerValue;
+    }
+  }
+});
+
 utils.freezeMethods(AxiosHeaders);
 
 export default AxiosHeaders;
diff --git a/lib/utils.js b/lib/utils.js
@@ -540,8 +540,9 @@ const reduceDescriptors = (obj, reducer) => {
   const reducedDescriptors = {};
 
   forEach(descriptors, (descriptor, name) => {
-    if (reducer(descriptor, name, obj) !== false) {
-      reducedDescriptors[name] = descriptor;
+    let ret;
+    if ((ret = reducer(descriptor, name, obj)) !== false) {
+      reducedDescriptors[name] = ret || descriptor;
     }
   });
 
diff --git a/test/unit/core/AxiosHeaders.js b/test/unit/core/AxiosHeaders.js
@@ -76,6 +76,17 @@ describe('AxiosHeaders', function () {
     })
   });
 
+  it('should support uppercase name mapping for names overlapped by class methods', () => {
+    const headers = new AxiosHeaders({
+      set: 'foo'
+    });
+
+    headers.set('get', 'bar');
+
+    assert.strictEqual(headers.get('Set'), 'foo');
+    assert.strictEqual(headers.get('Get'), 'bar');
+  });
+
   describe('get', function () {
     describe('filter', function() {
       it('should support RegExp', function () {

Original file line number	Diff line number	Diff line change
`@@ -10,5 +10,6 @@ module.exports = {`
`10`	`10`	`"sourceType": "module"`
`11`	`11`	`},`
`12`	`12`	`"rules": {`
	`13`	`+ "no-cond-assign": 0`
`13`	`14`	`}`
`14`	`15`	`}`