Skip to content

VPC CNI chart specifies min/ip target settings as windows only #1120

Open
@ryanwholey

Description

Describe the bug

I'm seeking clarity on why the warm/min IP target values have been grouped under Windows settings. From the documentation, both on the AWS EKS side as well as the VPC CNI side, they read as if Windows mode is not related. I believe they apply to non-windows node types as well (see the linux prefix delegation mode). I propose we update the chart to declassify them as Windows settings because they may be overlooked by linux-only cluster operators.

Steps to reproduce

Chart values: https://github.com/aws/eks-charts/blob/master/stable/aws-vpc-cni/values.yaml#L102-L104
EKS docs: https://aws.github.io/aws-eks-best-practices/networking/vpc-cni/
CNI docs: https://github.com/aws/amazon-vpc-cni-k8s/blob/master/docs/eni-and-ip-target.md

Expected outcome

Clarity as to why warm/min ip and warm prefix target values are categorized as windows settings. If these are found to not be windows-specific, I'm happy to submit a PR to add new inputs and deprecate or remove the old ones as yall see fit.

Environment

  • Chart name: aws-vpc-cni
  • Chart version: 1.18.2
  • Kubernetes version: 1.26
  • Using EKS (yes/no), if so version? yes, 1.26

Additional Context:

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions