-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(util-dynamodb): [WIP] DocumentClient with basic put operation #2031
Conversation
reason: the DynamoDB operations are not mixed with DocumentClient
Thank you!!! This is what we need. My only concern is the selection of Since you are only using |
* | Array | L | | ||
* | Object | M | | ||
* | Buffer, File, Blob, ArrayBuffer, DataView, and JavaScript typed arrays | B | | ||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe Set
is also marshalled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, we have marshall/unmarshall support for as this code reuses existing utilities.
The documentation was copied from DocumentClient in v2, and will need re-edit while polishing.
Did you mean the usage in the test code? You can use |
@trivikr What do you mean by "test code"? This looks like the actual implementation to me. |
By test code I meant the code used under testing in this implementation (under PR description). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excited to have this power in v3 sdk - thanks, @trivikr !
I liked the philosophy behind V3 and modular architecture. Having this package kind of goes against it. If one has a Lambda that does not require any writing or put item operations in a microservice world, it will still include unnecessary code when using this implementation of the DocumentClient. While the philosophy behind V3 is fully aligned with a distributed application model, backporting things in this way might be a little bit step backward instead. |
Superceded by #2062 |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs and link to relevant comments in this thread. |
Issue
Attempt to fix: #1223
Description
[WIP] DocumentClient with basic put operation
Testing
Tested with the following code:
With DocumentClient
Code
Output
With DynamoDBClient
Code
Output
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.