feat(stepfunctions-tasks): support dynamic values for Glue Job Worker Type #32453
Conversation
github-actions
bot
added
bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32453 +/- ##
=======================================
Coverage 78.67% 78.67%
=======================================
Files 107 107
Lines 7237 7237
Branches 1329 1329
=======================================
Hits 5694 5694
Misses 1357 1357
Partials 186 186
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GavinZZ
force-pushed
the
yuanhaoz/dynamic_worker
branch
from
4ce6094 to
b7916fd
Compare
aws-cdk-automation
added
the
pr/needs-maintainer-review
| * | ||
| * @default - must choose one of `workerType` or `workerTypeV2` | ||
| */ | ||
| readonly workerTypeV2?: WorkerTypeV2; |
There was a problem hiding this comment.
I wonder do we have a naming pattern for this kind of change? e.g. workerTypeV2 or workerTypeEnum
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The merge conditions cannot be satisfied due to failing checks:You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
@mergify update |
✅ Branch has been successfully updated |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #32359
Reason for this change
Now, I can't put the workers type dynamic from payload input in the state machine because it only accept a enum type workerType that its a enum and only accepts the define workers. If i pass a string that references the payload input it shows an error.
Description of changes
Turn the ENUM type
WorkerTypeto a class-based implementation. This should be backward compatible as there's no change on user side.Description of how you validated changes
New integ tests that use dynamic value for Worker type. When invoking StateMachine with the JSON payload, it will fetch the data correctly and invoke the Glue job with the current worker type and number of workers.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license