chore: fix C# build #31946
Merged
chore: fix C# build #31946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the generated C# code doesn't compile with this error: ``` error CS0115: 'VpcV2Base._Proxy.Ipv4IpamProvisionedCidrs': no suitable method found to override ``` Most likely because the property on the interface is declared as ``` readonly ipv4IpamProvisionedCidrs?: string[]; ``` But the implementor is declared as ``` public readonly ipv4IpamProvisionedCidrs: string[] = []; ``` And the types of those fields are different: `string[] | undefined` vs `string[]`.
mrgrain
approved these changes
Oct 30, 2024
moelasmar
approved these changes
Oct 30, 2024
xazhao
approved these changes
Oct 30, 2024
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the generated C# code doesn't compile with this error:
The reason is that the abstract base class that implements an interface doesn't have an abstract field for that interface.
Then when a subclass does implement it, it gets rendered to an
overridein C#, but there is no method to override.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license