fix(logs): DataProtectionPolicy not displaying properly in console
#31725
Conversation
github-actions
bot
added
bug
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
cam8001
changed the title
cam8001
changed the title
DataProtectionPolicy not displaying properly in console
cam8001
changed the title
DataProtectionPolicy not displaying properly in consoleDataProtectionPolicy not displaying properly in console
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
cam8001
changed the title
DataProtectionPolicy not displaying properly in consoleDataProtectionPolicy not displaying properly in console
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
cam8001
changed the title
DataProtectionPolicy not displaying properly in consoleDataProtectionPolicy not displaying properly in console
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This PR has been in the BUILD FAILING state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
Issue # (if applicable)
Closes #26728.
Reason for this change
PascalCasedDataProtectionPolicyconstruct inaws-logsgenerates properties withcamelCasedproperty namesdataIdentifierinstead ofDataIdentifiercamelCasedproperty names are not recognised by CloudFormation, and so the configuration is not applied.Description of changes
I have tried to sort this by explicitly specifying the keys in an object in the generation of the
CfnLogGroupinlog-group.ts.I'm not sure if I need to go one level deeper to do the same for
Statement, but the docs suggest so. It feels a little hacky to do ever deeper explicit specification of keys - if anyone else has any suggestions for a better approach, I'm very open to it!Description of how you validated changes
Updated tests in
loggroup.test.tsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license