fix(backup): validation for vault name fails when parameters are referred in the name #25943
Conversation
…referred in the name
|
|
github-actions
bot
added
beginning-contributor
github-actions
bot
added
effort/small
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
tam0ri
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
aws-cdk-automation
added
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
added
pr/needs-maintainer-review
| recoveryPointTags: { | ||
| stage: 'prod', | ||
| }, |
There was a problem hiding this comment.
Why is this removed from the existing integ test?
There was a problem hiding this comment.
I don't remember the intention at the time, but it might be by my mistake. These lines were introduced few days before I submitted this PR, so I guess that I took some miss operation in my local environment at the time. Anyway, thank you for your nice catching! I'll revert this change and regenerate snapshots.
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Validation for Backup vault name fails when parameters are referred in the name now. Current implementation simply validates vault name with regular expression described in CFn reference, so it does not consider the special characters for parameters. This PR solves the issue by checking props.backupVaultName is resolved.
Closes #21735
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license