Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): ComputeEnvironment implements IConnectable #21458

Merged
merged 10 commits into from
Aug 5, 2022
Merged

feat(batch): ComputeEnvironment implements IConnectable #21458

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8ad4dbd
feat(aws-batch): make ComputeEnvironment connectable
Aug 3, 2022
de70e41
Restore fargate integration tests
Aug 4, 2022
8fb31c4
doc: ComputeEnvironments are now connectable
Aug 4, 2022
c79b89d
doc: Added efs namespace to connectable example
Aug 4, 2022
75fccbf
Merge branch 'main' into connectableComputeEnvironment
tcutts Aug 4, 2022
2274990
Update packages/@aws-cdk/aws-batch/README.md
tcutts Aug 4, 2022
4e1d9eb
Added unit test for connectable ComputeEnvironment
Aug 4, 2022
74e6d49
Changes suggested in feedback for PR #21458
Aug 4, 2022
7a70ff8
Merge branch 'main' into connectableComputeEnvironment
tcutts Aug 4, 2022
375d4b7
Merge branch 'main' into connectableComputeEnvironment
mergify[bot] Aug 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
doc: Added efs namespace to connectable example
  • Loading branch information
Tim Cutts committed Aug 4, 2022
commit c79b89da0226efbeefac6a9d02e9b491d15b99d6
6 changes: 4 additions & 2 deletions packages/@aws-cdk/aws-batch/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,10 +79,12 @@ const spotEnvironment = new batch.ComputeEnvironment(this, 'MySpotEnvironment',
Compute Environments now implement the IConnectable interface, which means you can use
tcutts marked this conversation as resolved.
Show resolved Hide resolved
connections on other CDK resources to manipulate the security groups and allow access.

For example:
For example, allowing Compute Environments to access an EFS filesystem:
tcutts marked this conversation as resolved.
Show resolved Hide resolved

```ts
declare const fs: efs.Filesystem;
import * as efs from '@aws-cdk/aws-efs';

declare const fs: efs.FileSystem;
declare const ce: batch.ComputeEnvironment;

fs.connections.allowDefaultPortFrom(ce);
Expand Down