Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cognito: support email for multi-factor authentication (MFA) #31815

Closed
1 of 2 tasks
mazyu36 opened this issue Oct 19, 2024 · 3 comments · Fixed by #31816
Closed
1 of 2 tasks

cognito: support email for multi-factor authentication (MFA) #31815

mazyu36 opened this issue Oct 19, 2024 · 3 comments · Fixed by #31816
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@mazyu36
Copy link
Contributor

mazyu36 commented Oct 19, 2024

Describe the feature

Cognito now supports email for MFA.

Ref: https://aws.amazon.com/about-aws/whats-new/2024/09/amazon-cognito-user-pools-email-authentication-option/?nc1=h_ls

In CloudFormation, EMAIL_OTP was added to EnabledMfas property at October 15, 2024.

This options is not supported yet in L2 Construct.

Use Case

To use email MFA

Proposed Solution

Add email option to MfaSecondFactor.

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.162.0

Environment details (OS name and version, etc.)

All
@mazyu36 mazyu36 added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 19, 2024
@github-actions github-actions bot added the @aws-cdk/aws-cognito Related to Amazon Cognito label Oct 19, 2024
@mazyu36 mazyu36 mentioned this issue Oct 19, 2024
Merged
1 task
@ashishdhingra ashishdhingra self-assigned this Oct 21, 2024
@ashishdhingra ashishdhingra added p2 investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 21, 2024
@ashishdhingra
Copy link
Contributor

MfaSecondFactor is processed here, which is used to set enabledMfas when creating CfnUserPool object. EMAIL_OTP support needs to be set in enabledMfas.

@mazyu36 Thanks for the PR contribution.

@ashishdhingra ashishdhingra added effort/small Small work item – less than a day of effort and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Oct 21, 2024
@ashishdhingra ashishdhingra removed their assignment Oct 21, 2024
@mergify mergify bot closed this as completed in #31816 Oct 22, 2024
@mergify mergify bot closed this as completed in f9d6eef Oct 22, 2024
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/aws-cognito Related to Amazon Cognito effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(cognito): support email based MFA mazyu36/aws-cdk
2 participants
@mazyu36 @ashishdhingra