feat(pipes-enrichments): support API Gateway enrichment #31794
Conversation
github-actions
bot
added
effort/medium
aws-cdk-automation
added
the
pr/needs-community-review
|
|
||
| ### API Gateway (REST API) | ||
|
|
||
| API Gateway can be used to enrich events of a pipe. |
There was a problem hiding this comment.
Thanks for the PR @mazyu36 - I'm curious if you've considered ApiGatewayV2; whether or not the enrichment should cover that case as well, and if so whether that would be a separate construct or also handled by this design?
There was a problem hiding this comment.
ApigatewayV2(HTTP API) cannot be used because pipes only supports Apigateway(REST API).
The pipes documentation did not clearly state this.
Also, when I tried in the management console, I was unable to use the HTTP API.
There was a problem hiding this comment.
Got it. Can you maybe then also make this more clear in the README?
There was a problem hiding this comment.
Thanks. I've updated README.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-community-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #29384
Reason for this change
To support Amazon API Gateway enrichment for EventBridge pipes.
Description of changes
Add
ApiGatewayEnrichmentconstruct.Description of how you validated changes
Add unit tests and integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license