-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iot: configure AWS IoT logging #31357
Closed
1 of 2 tasks
badmintoncryer opened this issue
Sep 7, 2024
· 3 comments
· Fixed by #31352 or softwaremill/tapir#4137 · May be fixed by NOUIY/aws-solutions-constructs#133, NOUIY/aws-solutions-constructs#134 or ajobayer/aws-secure-environment-accelerator#4
Closed
1 of 2 tasks
iot: configure AWS IoT logging #31357
badmintoncryer opened this issue
Sep 7, 2024
· 3 comments
· Fixed by #31352 or softwaremill/tapir#4137 · May be fixed by NOUIY/aws-solutions-constructs#133, NOUIY/aws-solutions-constructs#134 or ajobayer/aws-secure-environment-accelerator#4
Labels
@aws-cdk/aws-iot
Related to AWS IoT
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Comments
badmintoncryer
added
feature-request
A feature should be added or improved.
needs-triage
This issue or PR still needs to be triaged.
labels
Sep 7, 2024
1 task
badmintoncryer
changed the title
iot: configure logging feature
iot: configure AWS IoT logging
Sep 8, 2024
This was referenced Sep 9, 2024
pahud
added
p2
effort/medium
Medium work item – several days of effort
and removed
needs-triage
This issue or PR still needs to be triaged.
labels
Sep 9, 2024
Thank you for the PR! |
Comments on closed issues and PRs are hard for our team to see. |
1 similar comment
Comments on closed issues and PRs are hard for our team to see. |
xazhao
pushed a commit
to xazhao/aws-cdk
that referenced
this issue
Sep 12, 2024
### Issue # (if applicable) Closes aws#31357. ### Reason for this change Cloudformation supports for configuring [AWS IoT logging](https://docs.aws.amazon.com/iot/latest/developerguide/configure-logging.html) but AWS CDK doesn't support it. We have to create [logging role](https://docs.aws.amazon.com/iot/latest/developerguide/configure-logging.html#configure-logging-role-and-policy) to enable IoT logging. It is not particularly difficult, but it is user-friendly if IAM roles are implicitly generated by CDK simultaneously. ### Description of changes - define `ILogging` interface - define `LoggingProps` - define `Logging` class - create `CfnLogging` - generate logging role ### Description of how you validated changes Added both unit and integ tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
@aws-cdk/aws-iot
Related to AWS IoT
effort/medium
Medium work item – several days of effort
feature-request
A feature should be added or improved.
p2
Describe the feature
To enable AWS IoT logging feature by AWS CDK.
Use Case
Cloudformation supports for configuring AWS IoT logging for all activities but AWS CDK doesn't support this.
To enable this feature, we have to setup logging role simultaneously. I believe it would be better to create the logging role implicitly using AWS CDK."
Proposed Solution
No response
Other Information
No response
Acknowledgements
CDK version used
2.155.0
Environment details (OS name and version, etc.)
irrelevant
The text was updated successfully, but these errors were encountered: