Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-ecs): add datapointsToAlarm / evaluationPeriods / treatMissingData support to ScalableTaskCount #31240

Closed
2 tasks
modosc opened this issue Aug 28, 2024 · 2 comments
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. feature-request A feature should be added or improved. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.

Comments

@modosc
Copy link

modosc commented Aug 28, 2024

Describe the feature

when using the ScalableTaskCount methods there's no option to set datapointsToAlarm / evaluationPeriods. these seem to default to 3 (i can't find the code that's responsible for this) and there's no way to change them after the fact.

there's also no way to set treatMissingData

Use Case

these values are editable in the web ui, i'd like to be able to edit/manage them in cdk.
image

Proposed Solution

add these to the appropriate props for each method (eg CpuUtilizationScalingProps, MemoryUtilizationScalingProps, etc).

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.136.0

Environment details (OS name and version, etc.)

macos

@modosc modosc added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 28, 2024
@github-actions github-actions bot added the @aws-cdk/aws-ecs Related to Amazon Elastic Container label Aug 28, 2024
@modosc modosc changed the title (aws-ecs): add datapointsToAlarm / evaluationPeriods support to ScalableTaskCount (aws-ecs): add datapointsToAlarm / evaluationPeriods / treatMissingData support to ScalableTaskCount Aug 28, 2024
@khushail khushail added investigating This issue is being investigated and/or work is in progress to resolve the issue. and removed needs-triage This issue or PR still needs to be triaged. labels Aug 29, 2024
@khushail khushail self-assigned this Aug 29, 2024
@ashishdhingra
Copy link
Contributor

ashishdhingra commented Aug 29, 2024

@modosc Good afternoon. Please refer StackOverflow article https://stackoverflow.com/questions/75276953/cdk-set-the-data-points-to-alarm-parameter-for-a-target-tracking-scaling-poli. So the resource you're looking for is creating a CloudWatch alarm (refer here), which contains the datapointsToAlarm attribute.

Thanks,
Ashish

@ashishdhingra ashishdhingra added response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days. and removed investigating This issue is being investigated and/or work is in progress to resolve the issue. labels Aug 29, 2024
@khushail khushail removed their assignment Aug 29, 2024
Copy link

github-actions bot commented Sep 1, 2024

This issue has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

@github-actions github-actions bot added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 1, 2024
@github-actions github-actions bot added closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. and removed closing-soon This issue will automatically close in 4 days unless further comments are made. labels Sep 6, 2024
@github-actions github-actions bot closed this as completed Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. feature-request A feature should be added or improved. p2 response-requested Waiting on additional info and feedback. Will move to "closing-soon" in 7 days.
Projects
None yet
Development

No branches or pull requests

3 participants