fix(apigatewayv2): trigger on websocket connect and disconnect is not working #27732
Conversation
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
…out how to get RouteId for apiCall Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
Signed-off-by: Sumu <[email protected]>
…ttps://github.com/aws/aws-cdk into sumughan/apigwv2-addroutes-integration-not-working
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
Signed-off-by: Sumu <[email protected]>
aws-cdk-automation
added
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
aws-cdk-automation
removed
the
pr/needs-maintainer-review
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
mergify
bot
deleted the
sumughan/apigwv2-addroutes-integration-not-working
branch
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Closes #19532
Lambda integrations for
$connectand$disconnectroutes were previously broken. Users would see this error message in the Lambda console:Fixing the path by removing the extra
*/from the code of the Lambda integration that adds permission, we no longer see that error message in the Lambda console as the path is now correct:I could not manage to figure out how to verify this change via an Integration test assertion. However, I added a new integration test file for Lambda
$connectand$disconnectintegrations on aWebSocketApi. The attached screenshots above also verify that this change works when I manually run it locally.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license