Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(glue-alpha): prefix validation logic is incorrect #27472

Merged
merged 5 commits into from
Oct 10, 2023
Merged

fix(glue-alpha): prefix validation logic is incorrect #27472

merged 5 commits into from
Oct 10, 2023

Conversation

mikewrighton
Copy link
Contributor

@mikewrighton mikewrighton commented Oct 9, 2023 •
edited
Loading

There was logic in aws-glue-alpha.Job that expected SparkUIProps.prefix to be specified in the form /prefix-name, instead of the more conventional prefix-name/. This fix addresses the validation and handling of this prefix field to support the correct format.

BREAKING CHANGE: SparkUIProps.prefix strings in the original /prefix-name format will now result in a validation error. To retain the same behavior, prefixes must be changed to the new prefix-name/ format.

Closes #27396.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Oct 9, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team October 9, 2023 21:13
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 9, 2023
aws-cdk-automation
aws-cdk-automation previously requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort labels Oct 9, 2023
@mikewrighton mikewrighton changed the title fix(aws-glue-alpha): Prefix validation logic is incorrect fix(glue-alpha): Prefix validation logic is incorrect Oct 9, 2023
@scanlonp scanlonp changed the title fix(glue-alpha): Prefix validation logic is incorrect fix(glue-alpha): prefix validation logic is incorrect Oct 9, 2023
@scanlonp scanlonp added the pr/do-not-merge This PR should not be merged at this time. label Oct 9, 2023
scanlonp
scanlonp approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@scanlonp scanlonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good. We should clean up the documentation in the SparkUIProps. Line 392 should be updated to reflect the new validation. Once that is done, feel free to merge.

@scanlonp scanlonp added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Oct 9, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 9, 2023 22:03

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mikewrighton mikewrighton marked this pull request as ready for review October 10, 2023 15:28
@mikewrighton mikewrighton removed the pr/do-not-merge This PR should not be merged at this time. label Oct 10, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: dafe1a7
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Oct 10, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit b898d3b into main Oct 10, 2023
11 checks passed
@mergify mergify bot deleted the mikewrighton-27396 branch October 10, 2023 17:44
@github-actions github-actions bot mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scanlonp scanlonp scanlonp approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
bug This issue is a bug. contribution/core This is a PR that came from AWS. effort/small Small work item – less than a day of effort p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(@aws-cdk/aws-glue-alpha): New Prefix check logic is not follow normal S3 prefix format
3 participants
@mikewrighton @aws-cdk-automation @scanlonp