Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iot-actions): iot rule https action l2 construct #25535

Merged
merged 22 commits into from
Jul 13, 2023
Merged

feat(iot-actions): iot rule https action l2 construct #25535

merged 22 commits into from
Jul 13, 2023

Conversation

cponfick
Copy link
Contributor

Implemented the L2 construct for the IoT Core HTTPS action.

Closes #25491 .


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 11, 2023

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 labels May 11, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 11, 2023 12:59
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@cponfick cponfick changed the title feat(aws-iot-actions): added iot https action l2 construct feat(iot-actions): added iot https action l2 construct May 11, 2023
@aws-cdk-automation aws-cdk-automation dismissed their stale review May 11, 2023 13:08

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 11, 2023
@cponfick cponfick changed the title feat(iot-actions): added iot https action l2 construct feat(iot-actions): iot rule https action l2 construct May 11, 2023
@cponfick
Copy link
Contributor Author

@pahud is there anything I have to do to get this reviewed?

otaviomacedo
otaviomacedo previously approved these changes Jun 14, 2023
@mergify
Copy link
Contributor

mergify bot commented Jun 14, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot dismissed otaviomacedo’s stale review June 15, 2023 08:06

Pull request has been modified.

@cponfick cponfick requested a review from otaviomacedo June 15, 2023 08:12
@cponfick
Copy link
Contributor Author

@otaviomacedo Mergify failed to merge the PR. In the error message it was suggested to manually update the branch. This removed the review. I am not sure what the actual problem was.

@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

1 similar comment
@aws-cdk-automation
Copy link
Collaborator

This PR cannot be merged because it has conflicts. Please resolve them. The PR will be considered stale and closed if it remains in an unmergeable state.

@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 21b1ad2
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3aee826 into aws:main Jul 13, 2023
@mergify
Copy link
Contributor

mergify bot commented Jul 13, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@cponfick cponfick deleted the 25491-iot-https-action branch July 13, 2023 18:50
colifran pushed a commit that referenced this pull request Jul 17, 2023
Implemented the L2 construct for the IoT Core HTTPS action.


Closes #25491 .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this pull request Jul 29, 2023
Implemented the L2 construct for the IoT Core HTTPS action.


Closes aws#25491 .

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-iot-actions): Add HTTPS action L2 Construct
3 participants