feat(apigatewayv2): allow websockets routes to return response to client #22984
Conversation
|
|
github-actions
bot
added
p2
beginning-contributor
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
|
I had to add an integration test to aws-apigatewayv2-integrations as I couldn't use a Mock integration in aws-apigatewayv2. |
emilrowland
requested review from
aws-cdk-automation and
Naumel
and removed request for
Naumel and
aws-cdk-automation
| * Should the route send a response to the client | ||
| * @default false | ||
| */ | ||
| readonly returnResponse?: boolean; |
There was a problem hiding this comment.
Given that the way this is being used when it is true, I'm not sure that boolean is the right value here. You're adding $default as the routeResponseSelectionExpression creating a whole object from this . Can you help me understand why a boolean here is the right user experience?
There was a problem hiding this comment.
Today the only valid value o the routeResponseSelectionExpression is $default or undefined. So to not overcomplicate it by passing a string I abstracted it to be a boolean instead.
See the quote below from https://docs.aws.amazon.com/apigateway/latest/developerguide/apigateway-websocket-api-selection-expressions.html
Evaluation of the route response selection expression produces a route response key. Eventually, this key will be used to choose from one of the RouteResponses associated with the API. However, currently only the $default key is supported.
But if we want to be more future proof we could change the attribute to be the actual routeResponseSelectionExpression and pass it a string.
packages/@aws-cdk/aws-apigatewayv2-integrations/test/websocket/integ.route-response.ts
Outdated
Show resolved
Hide resolved
mergify
bot
dismissed
TheRealAmazonKendra’s stale review
Pull request has been modified.
emilrowland
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.
|
@Mergifyio update |
❌ Base branch update has failedrefusing to allow a GitHub App to create or update workflow |
There was a problem hiding this comment.
lgtm, leaving do-not-merge so @TheRealAmazonKendra can take a look
|
@Mergifyio update |
❌ Base branch update has failedrefusing to allow a GitHub App to create or update workflow |
mergify
bot
dismissed
comcalvi’s stale review
Pull request has been modified.
TheRealAmazonKendra
removed
the
pr/do-not-merge
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
This PR allows WebSocket routes to return a response to the client.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license