Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(synthetics): expose lifecycle rules for generated artifacts bucket #22634

Closed
1 of 2 tasks
mackensen opened this issue Oct 25, 2022 · 2 comments · Fixed by #26290
Closed
1 of 2 tasks

(synthetics): expose lifecycle rules for generated artifacts bucket #22634

mackensen opened this issue Oct 25, 2022 · 2 comments · Fixed by #26290
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@mackensen
Copy link

Describe the feature

Allow passing Lifecycle Rules to the generated ArtifactsBucketLocation S3 bucket.

Use Case

If you do not specify an ArtifactsBucketLocation for a Canary an S3 bucket is created for you and cannot be changed afterward. This bucket sets props for encryption and forcing SSL but does not expose lifecycle rules, nor are lifecycle rules set in relation to the failureRetentionPeriod and successRetentionPeriod props on the Canary. The S3 bucket will grow indefinitely unless you manually specify lifecycle rules from the interface or CLI.

Proposed Solution

No response

Other Information

No response

Acknowledgements

  • I may be able to implement this feature request
  • This feature might incur a breaking change

CDK version used

2.43.1

Environment details (OS name and version, etc.)

macOS Monterey 12.6
@mackensen mackensen added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Oct 25, 2022
@github-actions github-actions bot added the @aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics label Oct 25, 2022
@kaizencc kaizencc added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Oct 27, 2022
@kaizencc kaizencc removed their assignment Oct 27, 2022
@kaizencc
Copy link
Contributor

@mackensen this sounds like something reasonable to support. Would be happy to review a PR submitted by the community on this.

mackensen added a commit to LafColITS/aws-cdk that referenced this issue Nov 10, 2022
@mackensen
feat(synthetics): expose lifecycle rules for auto-generated aritfact …
8e8cf85 
…buckets

This change exposes the lifecycle rules property for new and existing auto-generated artifact buckets so that workload owners can easily manage growth.

fixes aws#22634
mackensen added a commit to LafColITS/aws-cdk that referenced this issue Nov 10, 2022
@mackensen
feat(synthetics): expose lifecycle rules for auto-generated artifact …
7d6d05a 
…buckets

This change exposes the lifecycle rules property for new and existing auto-generated artifact buckets so that workload owners can easily manage growth.

fixes aws#22634
@mackensen mackensen mentioned this issue Nov 10, 2022
Closed
4 tasks
@kaizencc kaizencc mentioned this issue Jul 7, 2023
Merged
@mergify mergify bot closed this as completed in #26290 Jul 11, 2023
mergify bot pushed a commit that referenced this issue Jul 11, 2023
@kaizencc
feat(synthetics): lifecycle rules for auto-generated artifact buckets (…
ad0d40c 
…#26290)

A re-roll of #22863. Thanks for getting this started @mackensen!

This change exposes the lifecycle rules property for new and existing auto-generated artifact buckets so that workload owners can easily manage growth.

Fixes #22634

Co-authored-by:  Charles Fulton [email protected]

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

bmoffatt pushed a commit to bmoffatt/aws-cdk that referenced this issue Jul 29, 2023
@kaizencc @bmoffatt
feat(synthetics): lifecycle rules for auto-generated artifact buckets (…
0790b3f 
…aws#26290)

A re-roll of aws#22863. Thanks for getting this started @mackensen!

This change exposes the lifecycle rules property for new and existing auto-generated artifact buckets so that workload owners can easily manage growth.

Fixes aws#22634

Co-authored-by:  Charles Fulton [email protected]

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-synthetics Related to Amazon CloudWatch Synthetics effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(synthetics): lifecycle rules for auto-generated artifact buckets aws/aws-cdk
feat(synthetics): lifecycle rules for auto-generated artifact buckets LafColITS/aws-cdk
2 participants
@mackensen @kaizencc