feat(synthetics): runtime version syn-nodejs-puppeteer-3.7 #22610
Conversation
|
|
github-actions
bot
added
p2
beginning-contributor
There was a problem hiding this comment.
Perfect @pallymore, this looks great. Many thanks to actually updating an integ test to make sure that this deploys :). It looks like rutnimes 3.0 - 3.4 are scheduled to be deprecated on Nov 13, at that time I'll try to remember to update the docs to reflect that.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
kaizencc
changed the title
kaizencc
changed the title
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Hi @kaizencc - thanks for the approval. I thought about updating the old runtimes but I figured it might be better if we do it on/after the deprecation date 😬 btw the automatic workflow has failed: https://github.com/aws/aws-cdk/pull/22610/checks?check_run_id=9072203560 is there anything I can do to fix it on my side? should I update my base branch? thanks! |
|
@Mergifyio refresh |
✅ Pull request refreshed |
mergify
bot
dismissed
kaizencc’s stale review
Pull request has been modified.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
* adds a constant for nodejs runtime version 3.7 * Updated readme to use 3.7 because versions <= 3.4 are being deprecated * added a new integ test for 3.7 (and updated its snapshots) ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license