feat(gamelift): add Script L2 Construct for GameLift #22343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
beginning-contributor
otaviomacedo
reviewed
Oct 5, 2022
|
|
||
| constructor(s: Construct, i: string) { | ||
| super(s, i, { | ||
| environmentFromArn: scriptArn, |
There was a problem hiding this comment.
Not really used yet but I wanted to ensure Script env was linked to information provide as parameter (here the ARN)
| import { CfnScript } from './gamelift.generated'; | ||
|
|
||
| /** | ||
| * Represents a GameLift realtime server script. |
There was a problem hiding this comment.
I think the explanation from the "About" page communicates, in a short paragraph, what a script is:
Suggested change
| * Represents a GameLift realtime server script. | |
| * Your configuration and custom game logic for use with Realtime Servers. | |
| * Realtime Servers are provided by GameLift to use instead of a custom-built | |
| * game server. You configure Realtime Servers for your game clients by | |
| * creating a script using JavaScript, and add custom game logic as | |
| * appropriate to host game sessions for your players. You upload the Realtime | |
| * script to the GameLift service in the Regions where you plan to set up | |
| * fleets. | |
| * | |
| * @see https://docs.aws.amazon.com/gamelift/latest/developerguide/realtime-script-uploading.html |
I suggest you also copy the one for builds to the Build class.
There was a problem hiding this comment.
Agreed. Update done
otaviomacedo
previously approved these changes
Oct 5, 2022
mergify
bot
dismissed
otaviomacedo’s stale review
Pull request has been modified.
otaviomacedo
approved these changes
Oct 5, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
arewa
pushed a commit
to arewa/aws-cdk
that referenced
this pull request
Oct 8, 2022
Following [aws-cdk-rfcs](aws/aws-cdk-rfcs#436) I have written the first Script L2 resource which create a GameLift Script resource based on a S3 location. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
homakk
pushed a commit
to homakk/aws-cdk
that referenced
this pull request
Dec 1, 2022
Following [aws-cdk-rfcs](aws/aws-cdk-rfcs#436) I have written the first Script L2 resource which create a GameLift Script resource based on a S3 location. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following aws-cdk-rfcs I have written the first Script L2 resource which create a GameLift Script resource based on a S3 location.
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license