feat(redshift): adds elasticIp parameter to redshift cluster #21085

daschaa · 2022-07-10T16:55:36Z

Fixes #19191.

Adds the property elasticIp to the ClusterProps.

All Submissions:

Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

This PR adds new unconventional dependencies following the process described here

New Features

Have you added the new feature to an integration test?
- Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

gitpod-io · 2022-07-10T16:55:42Z

corymhall

@daschaa it looks like there are some additional considerations when creating a public redshift cluster and using an elasticIP https://docs.aws.amazon.com/redshift/latest/mgmt/managing-clusters-vpc.html.

Can you update the README to have a section that discusses this?

daschaa · 2022-07-11T20:04:44Z

@daschaa it looks like there are some additional considerations when creating a public redshift cluster and using an elasticIP https://docs.aws.amazon.com/redshift/latest/mgmt/managing-clusters-vpc.html.

Can you update the README to have a section that discusses this?

Of course! Thanks for the feedback.
In the link you provided is a really good section about the elastic ip configuration. Quote:

If you configure your cluster to be publicly accessible, you can optionally select an elastic IP address to use for the external IP address. An elastic IP address is a static IP address that is associated with your AWS account. You can use an elastic IP address to connect to your cluster from outside the VPC. An elastic IP address gives you the ability to change your underlying configuration without affecting the IP address that clients use to connect to your cluster. This approach can be helpful for situations such as recovery after a failure.

Is it ok to copy this to the readme? Imho it explains it very good and simple. :)

corymhall · 2022-07-12T12:30:24Z

Is it ok to copy this to the readme? Imho it explains it very good and simple. :)

yeah I think that is fine. Some of the other items I think it is important to include:

The piece around connecting from within the VPC (with a code example showing the VPC configuration)
The note around giving the cluster an elastic IP before making the VPC configuration (only active after a resize)
When to use the elasticIP vs the clusterEndpointAddress
How to attach or change the ip after the cluster has been completed.

Pull request has been modified.

daschaa · 2022-07-12T19:06:42Z

@corymhall I updated the Readme and added the section about the elastic ip. I hope everything is ok - it would be great if you could double check.

In the topic of when to use elastic ip vs. cluster endpoint I'm not quite sure how to formulate it. As far as I understand it, the elastic ip should only be used when you need to have a static ip which you use to connect to the Redshift Cluster and the cluster endpoint is more dynamic, because it is a DNS address which is generated. Is it correct?

And the last thing about changing the ip after the cluster has been completed I do not quite understand. Could you give me a hint where to look regarding this topic?

Thanks in advance! ❤️

corymhall · 2022-07-13T12:33:18Z

And the last thing about changing the ip after the cluster has been completed I do not quite understand. Could you give me a hint where to look regarding this topic?

It's near the bottom of that page:

The option to associate a cluster with an elastic IP address is available when you create the cluster or restore the cluster from a snapshot. In some cases, you might want to associate the cluster with an elastic IP address or change an elastic IP address that is associated with the cluster. To attach an elastic IP address after the cluster is created, first update the cluster so that it is not publicly accessible, then make it both publicly accessible and add an Elastic IP address in the same operation.

In the topic of when to use elastic ip vs. cluster endpoint I'm not quite sure how to formulate it.

I would just take from this portion. I think the important thing to not is just that they are not the same thing. There might be some confusion if there is a public elasticIP and a public node ip address.

The elastic IP address is an external IP address for accessing the cluster outside of a VPC. It's not related to the cluster node public IP addresses and private IP addresses that are displayed in the Amazon Redshift console under Connection details. The public and private cluster node IP addresses appear regardless of whether the cluster is publicly accessible or not. They are used only in certain circumstances to configure ingress rules on the remote host. These circumstances occur when you load data from an Amazon EC2 instance or other remote host using a Secure Shell (SSH) connection.

daschaa · 2022-07-14T18:57:50Z

@corymhall Thank you very much for the hints! I added the sections you mentioned in your comment.

corymhall

@daschaa awesome! love the readme updates ❤️

mergify · 2022-07-15T13:03:26Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

daschaa · 2022-07-15T13:49:25Z

@corymhall Are the tests flaky? Because I did not change anything I think..

mrgrain · 2022-07-18T17:08:41Z

@Mergifyio update

mergify · 2022-07-18T17:09:50Z

update

✅ Branch has been successfully updated

aws-cdk-automation · 2022-07-18T17:46:11Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 638abec
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2022-07-18T17:46:13Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Fixes aws#19191. Adds the property `elasticIp` to the `ClusterProps`. ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*

✨ feat(redshift): adds elasticIp parameter to redshift cluster

02cb331

aws-cdk-automation requested a review from a team July 10, 2022 16:55

github-actions bot added p2 feature-request A feature should be added or improved. p1 and removed p2 labels Jul 10, 2022

corymhall previously requested changes Jul 11, 2022

View reviewed changes

📝 Adds more information to README and integ test

a756459

Merge branch 'main' into redshift_elastic_ip

593cecc

🚨 Fixes linter warnings

3fed76b

📝 Updates README

b0727b1

corymhall approved these changes Jul 15, 2022

View reviewed changes

Merge branch 'main' into redshift_elastic_ip

13292f0

Merge branch 'main' into redshift_elastic_ip

638abec

mergify bot merged commit c88030f into aws:main Jul 18, 2022

daschaa deleted the redshift_elastic_ip branch July 18, 2022 20:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(redshift): adds elasticIp parameter to redshift cluster #21085

feat(redshift): adds elasticIp parameter to redshift cluster #21085

daschaa commented Jul 10, 2022 •

edited

Loading

gitpod-io bot commented Jul 10, 2022

corymhall left a comment

daschaa commented Jul 11, 2022

corymhall commented Jul 12, 2022

daschaa commented Jul 12, 2022 •

edited

Loading

corymhall commented Jul 13, 2022

daschaa commented Jul 14, 2022

corymhall left a comment

mergify bot commented Jul 15, 2022

daschaa commented Jul 15, 2022

mrgrain commented Jul 18, 2022

mergify bot commented Jul 18, 2022

aws-cdk-automation commented Jul 18, 2022

mergify bot commented Jul 18, 2022

feat(redshift): adds elasticIp parameter to redshift cluster #21085

feat(redshift): adds elasticIp parameter to redshift cluster #21085

Conversation

daschaa commented Jul 10, 2022 • edited Loading

All Submissions:

Adding new Unconventional Dependencies:

New Features

gitpod-io bot commented Jul 10, 2022

corymhall left a comment

Choose a reason for hiding this comment

daschaa commented Jul 11, 2022

corymhall commented Jul 12, 2022

daschaa commented Jul 12, 2022 • edited Loading

corymhall commented Jul 13, 2022

daschaa commented Jul 14, 2022

corymhall left a comment

Choose a reason for hiding this comment

mergify bot commented Jul 15, 2022

daschaa commented Jul 15, 2022

mrgrain commented Jul 18, 2022

mergify bot commented Jul 18, 2022

✅ Branch has been successfully updated

aws-cdk-automation commented Jul 18, 2022

AWS CodeBuild CI Report

mergify bot commented Jul 18, 2022

daschaa commented Jul 10, 2022 •

edited

Loading

daschaa commented Jul 12, 2022 •

edited

Loading