Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(redshift): expose user.secret as property (#17520) #20078

Merged
merged 6 commits into from
Apr 27, 2022
Merged

feat(redshift): expose user.secret as property (#17520) #20078

merged 6 commits into from
Apr 27, 2022

Conversation

Ahmed-Hussein93
Copy link
Contributor

@Ahmed-Hussein93 Ahmed-Hussein93 commented Apr 25, 2022 •
edited
Loading

This change will expose Redshift User.secret as property and close #17520

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

New Features

  • Have you added the new feature to an integration test?
    • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 25, 2022

@aws-cdk-automation aws-cdk-automation requested a review from a team April 25, 2022 21:10
@github-actions github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 labels Apr 25, 2022
TheRealAmazonKendra
TheRealAmazonKendra previously requested changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@TheRealAmazonKendra TheRealAmazonKendra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your submission! This change will need a documentation update in the README before we can approve it. It looks good, though, besides one or two little nit items.

@mergify mergify bot dismissed TheRealAmazonKendra’s stale review April 26, 2022 15:52

Pull request has been modified.

@TheRealAmazonKendra TheRealAmazonKendra added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label Apr 27, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 91e944e
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 27, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 8da006a into aws:master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdennis alexdennis alexdennis left review comments

@TheRealAmazonKendra TheRealAmazonKendra TheRealAmazonKendra approved these changes

Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1 pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(redshift): expose User.secret as property
4 participants
@Ahmed-Hussein93 @aws-cdk-automation @alexdennis @TheRealAmazonKendra