feat(integ-runner): add missing features from the integ manifest #19969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally the integ-runner was built to work with the "legacy" integration tests since that is all we currently have. Since then we have published the `integ-tests` library which adds support for the integ manifest. This PR adds additional coverage for the integ manifest. To make the implementation a little cleaner I've extracted the logic that deals with the manifest into `IntegTestCases` and `LegacyIntegTestCases` classes. This allows the runner to just deal with the manifest and not have to worry about handling where it came from. I've also split up the `runners.ts`/`runners.test.ts` into `integ-test-runner.ts`, `runner-base.ts`, and `snapshot-test-runner.ts` Coverage added: 1. `stackUpdateWorkflow` - This was moved from the individual `testCase` to the manifest. This means that we will enable or disable the update workflow at the test level instead of the individual test case level. This also required a bump in the schema version. 2. `diffAssets` 3. `hooks`
|
|
corymhall
added
the
pr-linter/exempt-integ-test
otaviomacedo
added
the
pr/do-not-merge
otaviomacedo
approved these changes
Apr 20, 2022
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
StevePotter
pushed a commit
to StevePotter/aws-cdk
that referenced
this pull request
Apr 27, 2022
…#19969) Originally the integ-runner was built to work with the "legacy" integration tests since that is all we currently have. Since then we have published the `integ-tests` library which adds support for the integ manifest. This PR adds additional coverage for the integ manifest. To make the implementation a little cleaner I've extracted the logic that deals with the manifest into `IntegTestCases` and `LegacyIntegTestCases` classes. This allows the runner to just deal with the manifest and not have to worry about handling where it came from. I've also split up the `runners.ts`/`runners.test.ts` into `integ-test-runner.ts`, `runner-base.ts`, and `snapshot-test-runner.ts` Coverage added: 1. `stackUpdateWorkflow` 2. `diffAssets` 3. `hooks` ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally the integ-runner was built to work with the "legacy"
integration tests since that is all we currently have. Since then
we have published the
integ-testslibrary which adds supportfor the integ manifest. This PR adds additional coverage for the
integ manifest.
To make the implementation a little cleaner I've extracted the logic
that deals with the manifest into
IntegTestCasesandLegacyIntegTestCasesclasses. This allows the runner to just deal withthe manifest and not have to worry about handling where it came from.
I've also split up the
runners.ts/runners.test.tsintointeg-test-runner.ts,runner-base.ts, andsnapshot-test-runner.tsCoverage added:
stackUpdateWorkflowdiffAssetshooksAll Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license