Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: aws/aws-cdk
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v2.0.0-alpha.2
Choose a base ref
...
head repository: aws/aws-cdk
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v2.0.0-alpha.3
Choose a head ref
  • 5 commits
  • 12 files changed
  • 5 contributors

Commits on Jan 26, 2021

  1. feat(aws-codebuild): add enableBatchBuilds() to Project (#12531)

    In order for a CodeBuild to run in batch mode, a batch service role is needed, as described [here in the docs](https://docs.aws.amazon.com/codebuild/latest/userguide/batch-build.html).
    
    >Batch builds introduce a new security role in the batch configuration. This new role is required as CodeBuild must be able to call the StartBuild, StopBuild, and RetryBuild actions on your behalf to run builds as part of a batch. Customers should use a new role, and not the same role they use in their build...
    
    At first I thought lets add this by default, but then I realised when `BatchConfiguration` is set to something, in the aws console the default 'start build' button behaviour changes to start a batch build by default instead :/
    
    So now this adds a new `supportBatchBuildType` option, which when `true` adds minimum amount of `BatchConfiguration` needed for batch builds to run.
    
    I also updated the doc blocks for the webhook option and CodePipeline action option, because users of those also need to set this option. It would be nice to auto-enable this if a webhook or CodeBuild action is configured, but that sounds pretty complicated.
    
    I'm not sure why anyone would need to customise this role, given it appears to only be used internally to do those 3 things, so this PR does not make it configurable. My thinking is that this could be added later if needed, but this PR just gets batch builds working.
    
    In the future if people want control of the other `BatchConfiguration` options I was thinking these could be added and would require `supportBatchBuildType` to be `true`.
    
    related: aws-cloudformation/cloudformation-coverage-roadmap#621
    tjenkinson authored Jan 26, 2021
    Configuration menu
    Copy the full SHA
    0568390 View commit details
    Browse the repository at this point in the history
  2. feat(batch): Compute Resources placement group (#12203)

    Closes #12175
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    ridha authored Jan 26, 2021
    Configuration menu
    Copy the full SHA
    fe37174 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Merge remote-tracking branch 'origin/master' into v2-main

    Niranjan Jayakar committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    4a0e1ae View commit details
    Browse the repository at this point in the history
  2. chore: forward merge 'master' into 'v2-main' (#12726)

    Manually resolved files:
    - packages/@aws-cdk/aws-codebuild/lib/project.ts
    - packages/@aws-cdk/aws-codebuild/lib/source.ts
    
    ----
    
    *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
    mergify[bot] authored Jan 27, 2021
    Configuration menu
    Copy the full SHA
    0b491cf View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2021

  1. Configuration menu
    Copy the full SHA
    80057e1 View commit details
    Browse the repository at this point in the history
Loading