Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation build fail #18

Open
Logarithmus opened this issue May 2, 2020 · 3 comments
Open

Documentation build fail #18

Logarithmus opened this issue May 2, 2020 · 3 comments

Comments

@Logarithmus
Copy link
Contributor

It seems that documentation failed to build for 0.3.0:
https://docs.rs/crate/avrd/0.3.0

If you look at the build log, there's a panic with message "Read-only filesystem". I think it's docs.rs problem. But why 0.2.0 built successfully? Is it a regression?
@dylanmckay
Copy link
Member

Read-only filesystem

That makes sense - crate currently generates .rs files for the MCU cores in the build.rs script ) (

avrd/build.rs

Line 29 in 3e75477

gen::all(&crate_root.join("src").join("gen"), &mcus).unwrap();
). It is discouraged to generate sources at runtime.

The best solution here would be to adapt the build.rs script into a script that can be run by the crate maintainers to update the autogenerated MCU core files so that they can be added into version control permanently. This will also make crate compilation much faster.

@shepmaster
Copy link
Member

Plenty of crates Use build scripts to generate source code, so I don’t know why this would be a problem.

@schulzch
Copy link

schulzch commented Aug 9, 2020 •
edited
Loading

Plenty of crates Use build scripts to generate source code, so I don’t know why this would be a problem.

As far as I know, only OUT_DIR is writable.

@schulzch schulzch mentioned this issue Aug 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@shepmaster @schulzch @dylanmckay @Logarithmus