Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme loading error isn't shown #2552

Open
datenimperator opened this issue Jan 7, 2025 · 1 comment
Open

Theme loading error isn't shown #2552

datenimperator opened this issue Jan 7, 2025 · 1 comment

Comments

@datenimperator
Copy link

During loading a custom theme, errors may arise as exceptions. The rescue statement will silently discard them, making it very hard to understand what actually went wrong.

asciidoctor-pdf/lib/asciidoctor/pdf/converter.rb

Line 563 in b154248

rescue

I propose to have something along the lines of

# ...
rescue Exception => ex
  logger.error ex
# ...

to help with debugging. If feasible, I'm happy to provide a pull request.
@mojavelinux
Copy link
Member

That seems reasonable to me. You may proceed with preparing a pull request and I will review it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mojavelinux @datenimperator