Remove the Array.prototype.map polyfill #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe libraries should usually not pollute the global namespace and should therefore also not modify native prototypes. In addition Array.prototype.map is supported in all modern browsers (even IE 9 onwards) so I believe this is safe to drop in the end of 2017. For people who need to support even older browser there are enough transpiling solutions these days.
|
Hi Ctavan, Thanks for the suggestion. Perfectly right about the non-pollution thing. Laurent |
|
@LaurentVB thanks for the feedback. Does that mean that you're currently actively working on a rewrite? Or would you rather suggest that I start my own fork if I need a polyfill-less variant in the near future? |
|
@LaurentVB any update on that one? More than a year later, IE8- is less relevant than ever before... Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe libraries should usually not pollute the global namespace and
should therefore also not modify native prototypes.
In addition Array.prototype.map is supported in all modern browsers
(even IE 9 onwards) so I believe this is safe to drop in the end of
2017.
For people who need to support even older browser there are enough
transpiling solutions these days.