Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for ESP if UEFI boot #2283

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codefiles
Copy link
Contributor

@codefiles codefiles commented Dec 3, 2023

Resolves #2157

  • Add _invalid_configs() for future addition of checks for invalid configurations
  • Add Install (n config(s) invalid) to the install text when an invalid configuration is detected
  • List invalid configurations in bullet form

The last two bullets are replications of the behavior for missing configurations.

@codefiles
Copy link
Contributor Author

codefiles commented Dec 9, 2023

The EFI system partition "is mandatory for UEFI boot." [1] This pull request needs to be changed to apply to when UEFI boot is detected instead of just systemd-boot.

[1] https://wiki.archlinux.org/title/EFI_system_partition

@codefiles codefiles changed the title Check for ESP if systemd-boot selected Check for ESP if UEFI boot Dec 15, 2023
@codefiles codefiles marked this pull request as draft December 15, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

['/usr/bin/arch-chroot', '/mnt/archinstall', 'bootctl', '--no-variables', 'install'] exited with abnormal exit code [1]:
1 participant