Do not use BuilderLeaser in PathValidator (#22162)

markuspf · web-flow · commit 337baba269fe · 2025-12-05T15:38:56.000+01:00
For queries that use async prefetch this leads to concurrent use of
the transaction context. The transaction context is not safe for use
concurrently.
diff --git a/arangod/Graph/PathManagement/PathValidator.cpp b/arangod/Graph/PathManagement/PathValidator.cpp
@@ -282,8 +282,8 @@ auto PathValidator<ProviderType, PathStore, vertexUniqueness, edgeUniqueness>::
     return ValidationResult{ValidationResult::Type::FILTER_AND_PRUNE};
   }
 
-  auto vertexBuilder = transaction::BuilderLeaser(_provider.trx());
-  auto edgeBuilder = transaction::BuilderLeaser(_provider.trx());
+  auto vertexBuilder = std::make_unique<VPackBuilder>();
+  auto edgeBuilder = std::make_unique<VPackBuilder>();
 
   // evaluate if vertex needs to be pruned
   ValidationResult res{ValidationResult::Type::TAKE};

Original file line number	Diff line number	Diff line change
`@@ -282,8 +282,8 @@ auto PathValidator<ProviderType, PathStore, vertexUniqueness, edgeUniqueness>::`
`282`	`282`	`return ValidationResult{ValidationResult::Type::FILTER_AND_PRUNE};`
`283`	`283`	`}`
`284`	`284`
`285`		`- auto vertexBuilder = transaction::BuilderLeaser(_provider.trx());`
`286`		`- auto edgeBuilder = transaction::BuilderLeaser(_provider.trx());`
	`285`	`+ auto vertexBuilder = std::make_unique<VPackBuilder>();`
	`286`	`+ auto edgeBuilder = std::make_unique<VPackBuilder>();`
`287`	`287`
`288`	`288`	`// evaluate if vertex needs to be pruned`
`289`	`289`	`ValidationResult res{ValidationResult::Type::TAKE};`