Add Config active_if_environment helper #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Help people configure AppSignal using the `Appsignal.configure` helper more easily by adding the `activate_if_environment` helper within that DSL context. This helper will automate setting `active` to `true` if the loaded environment matches one of the values given. This way people don't have build their own conditionals to set active true for certain environments.
luismiramirez
approved these changes
Oct 31, 2024
unflxw
approved these changes
Nov 1, 2024
This is a message from the daily scheduled checks. |
Yes. It's to promote this pattern of setting the active option using the AppSignal env, rather than use For example: this scenario where the rails env is production in staging and AppSignal shouldn't be active in staging. ENV["RAILS_ENV"] = "production"
ENV["APPSIGNAL_APP_ENV"] = "staging"
# config/initializers/appsignal.rb
Appsignal.configure do |config|
config.env # => "staging"
config.active = Rails.env.production?
end |
[skip ci] Co-authored-by: Noemi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help people configure AppSignal using the
Appsignal.configurehelper more easily by adding theactivate_if_environmenthelper within that DSL context.This helper will automate setting
activetotrueif the loaded environment matches one of the values given.This way people don't have build their own conditionals to set active true for certain environments.